Re: sfdisk, latest fixes break ppc64

[Karel Zak <kzak@redhat.com>]

On Wed, Apr 22, 2015 at 12:42:18PM +0200, Ruediger Meier wrote:
> On Wednesday 22 April 2015, Karel Zak wrote:
> > On Tue, Apr 21, 2015 at 12:34:26PM +0200, Ruediger Meier wrote:
> > > the latest sfdisk fixes 2928068a..a53e37f9 seem to break ppc64
> >
> > The latest changes in sfdisk only shows stupid LE/BE bugs we have in
> > GPT code. The problem should be fixed now.
> 
> Most issues are fixed now so I guess 2.26.2 will be a good one :)

 I hope so:-) Next time it would be nice to detect and fix such bugs
 in major release or in .1  ... we need a way how to motivate users to
 use -rc releases (t-shits, beers? ;-)

> There are still some random failures sometimes like this:
> 
>              : resize                      ... FAILED (sfdisk/gpt-resize)
> ....
> [  604s] --- /home/abuild/rpmbuild/BUILD/util-linux-2.26.git233.01aa/tests/expected/sfdisk/gpt-resize	2015-04-22 06:40:45.002363998 +0000
> [  604s] +++ /home/abuild/rpmbuild/BUILD/util-linux-2.26.git233.01aa/tests/output/sfdisk/gpt-resize	2015-04-22 10:22:27.514581956 +0000
> [  604s] @@ -1,3 +1,4 @@
> [  604s] +Re-reading the partition table failed.: Device or resource busy
> [  604s]  Checking that no-one is using this disk right now ... OK
> [  604s]  
> [  604s]  Disk <removed>: 50 MiB, 52428800 bytes, 102400 sectors
> [  604s] @@ -20,4 +21,5 @@
> [  604s]  
> [  604s]  The partition table has been altered.
> [  604s]  Calling ioctl() to re-read partition table.
> [  604s] +The kernel still uses the old table. The new table will be used at the next reboot or after you run partprobe(8) or kpartx(8).
> [  604s]  Syncing disks.

Yes, I know about it, but I'm able to reproduce this only on ppc, add
"sleep 10" to the test fixes the problem, so I guess that "udevadm
settle" is not so reliable on ppc.

Note that I'm working on new resize code, so this test will go away
and it will be replaced with separated "resize" test script.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com