Util-Linux package development
 help / color / mirror / Atom feed
From: Ruediger Meier <sweet_f_a@gmx.de>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: sfdisk, latest fixes break ppc64
Date: Wed, 22 Apr 2015 16:20:01 +0200	[thread overview]
Message-ID: <201504221620.01771.sweet_f_a@gmx.de> (raw)
In-Reply-To: <20150422132827.GF27969@ws.net.home>

On Wednesday 22 April 2015, Karel Zak wrote:
> On Wed, Apr 22, 2015 at 12:42:18PM +0200, Ruediger Meier wrote:
> > On Wednesday 22 April 2015, Karel Zak wrote:
> > > On Tue, Apr 21, 2015 at 12:34:26PM +0200, Ruediger Meier wrote:
> > > > the latest sfdisk fixes 2928068a..a53e37f9 seem to break ppc64
> > >
> > > The latest changes in sfdisk only shows stupid LE/BE bugs we have
> > > in GPT code. The problem should be fixed now.
> >
> > Most issues are fixed now so I guess 2.26.2 will be a good one :)
>
>  I hope so:-) Next time it would be nice to detect and fix such bugs
>  in major release or in .1  ... we need a way how to motivate users
> to use -rc releases (t-shits, beers? ;-)

Hehe, maybe the only way is like we have it right now. 2.xx and 2.xx.1 
are the real rc1 and rc2. The distributors have to learn to use 2.xx.2 
only ;)

> > There are still some random failures sometimes like this:
> >              : resize                      ... FAILED
> >              : (sfdisk/gpt-resize)

> Yes, I know about it, but I'm able to reproduce this only on ppc, add
> "sleep 10" to the test fixes the problem, so I guess that "udevadm
> settle" is not so reliable on ppc.

Yes, I've also made many experiments about this.

For example currently I'am always using
  export BLKID_CONF="/dev/null"

to avoid arbitrary /etc/blkid.conf from build hosts. This makes sure 
that you always use "EVALUATE=scan" and it seems to fix 
random "blkdiscard" failures.

And I've also tried something like this partially succesful:

@@ -497,10 +497,14 @@ function ts_device_deinit {
 }
 
 function ts_uuid_by_devname {
+	echo change > /sys/block/$(basename $1)/uevent
+	udevadm settle
 	echo $($TS_CMD_BLKID -p -s UUID -o value $1)
 }
 
 function ts_label_by_devname {
+	echo change > /sys/block/$(basename $1)/uevent
+	udevadm settle
 	echo $($TS_CMD_BLKID -p -s LABEL -o value $1)
 }

cu,
Rudi

  reply	other threads:[~2015-04-22 14:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-21 10:34 sfdisk, latest fixes break ppc64 Ruediger Meier
2015-04-22 10:13 ` Karel Zak
2015-04-22 10:42   ` Ruediger Meier
2015-04-22 13:28     ` Karel Zak
2015-04-22 14:20       ` Ruediger Meier [this message]
2015-04-22 14:50         ` Bernhard Voelker
2015-04-22 15:46           ` Karel Zak
2015-04-22 16:10             ` Ruediger Meier
2015-04-22 16:02           ` Ruediger Meier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201504221620.01771.sweet_f_a@gmx.de \
    --to=sweet_f_a@gmx.de \
    --cc=kzak@redhat.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox