cfdisk cuts lines for logical partitions too short

cfdisk cuts lines for logical partitions too short

[Benno Schulenberg]

Hi Karel,

In 2.27, the highlight bar of cfdisk is three or four characters
shorter than the width of the screen -- for logical partitions.
I noticed because on a 100-column terminal two letters of a
translation were bitten off.

The culprit is commit ed99eac0e2a83a315c7cf5d8a461df16b3106596.
Before that, the lines were full length.


Btw, in current git, running ./cfdisk aborts here with:

  lt-cfdisk: libblkid/src/probe.c:638: mmap_buffer: 
  Assertion `map_off + map_len >= real_off + len' failed.


Benno

-- 
http://www.fastmail.com - Choose from over 50 domains or use your own

Re: cfdisk cuts lines for logical partitions too short

[Benno Schulenberg]

On Wed, Nov 18, 2015, at 17:04, Benno Schulenberg wrote:
> In 2.27, the highlight bar of cfdisk is three or four characters
> shorter than the width of the screen -- for logical partitions.
> I noticed because on a 100-column terminal two letters of a
> translation were bitten off.
> 
> The culprit is commit ed99eac0e2a83a315c7cf5d8a461df16b3106596.
> Before that, the lines were full length.

Ping?


> Btw, in current git, running ./cfdisk aborts here with:
> 
>   lt-cfdisk: libblkid/src/probe.c:638: mmap_buffer: 
>   Assertion `map_off + map_len >= real_off + len' failed.

Okay.  That works now.

Benno

-- 
http://www.fastmail.com - Access all of your messages and folders
                          wherever you are

Re: cfdisk cuts lines for logical partitions too short

[Karel Zak]

On Wed, Nov 18, 2015 at 05:04:40PM +0100, Benno Schulenberg wrote:
> In 2.27, the highlight bar of cfdisk is three or four characters
> shorter than the width of the screen -- for logical partitions.
> I noticed because on a 100-column terminal two letters of a
> translation were bitten off.
> 
> The culprit is commit ed99eac0e2a83a315c7cf5d8a461df16b3106596.
> Before that, the lines were full length.

.. because it (incorrectly) counts escape seq. to the size of the
header line. I'll try to fix it.

Thanks.

    Karel


-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

Re: cfdisk cuts lines for logical partitions too short

[Karel Zak]

On Wed, Nov 18, 2015 at 05:04:40PM +0100, Benno Schulenberg wrote:
> In 2.27, the highlight bar of cfdisk is three or four characters
> shorter than the width of the screen -- for logical partitions.
> I noticed because on a 100-column terminal two letters of a
> translation were bitten off.

 Probably fixed -- I'm not sure if I have found the same bugs like
 you :-) 
 
 Test it please. Thanks!

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

Re: cfdisk cuts lines for logical partitions too short

[Benno Schulenberg]

On Mon, Dec 7, 2015, at 12:25, Karel Zak wrote:
> On Wed, Nov 18, 2015 at 05:04:40PM +0100, Benno Schulenberg wrote:
> > In 2.27, the highlight bar of cfdisk is three or four characters
> > shorter than the width of the screen -- for logical partitions.
> > I noticed because on a 100-column terminal two letters of a
> > translation were bitten off.
> 
>  Probably fixed -- I'm not sure if I have found the same bugs like
>  you :-) 

Tested.  Looks good now.  Thanks!

Benno

-- 
http://www.fastmail.com - Accessible with your email software
                          or over the web