[PATCH] build: uuidd requires linux now, uses signalfd

[PATCH] build: uuidd requires linux now, uses signalfd

[Andreas Henriksson]

Specify that uuidd can only be built on Linux now since
commit 25d66b4e3232d7b "uuidd: use signalfd() and setup_timer()"

Signed-off-by: Andreas Henriksson <andreas@fatal.se>
---
 configure.ac | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configure.ac b/configure.ac
index 8d808b7..e5ee3fb 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1079,6 +1079,7 @@ AC_ARG_ENABLE([uuidd],
   [], [UL_DEFAULT_ENABLE([uuidd], [check])]
 )
 UL_BUILD_INIT([uuidd])
+UL_REQUIRES_LINUX([uuidd])
 UL_REQUIRES_BUILD([uuidd], [libuuid])
 AS_IF([test "x$build_uuidd" = xyes], [
   AC_DEFINE([HAVE_UUIDD], [1], [Define to 1 if you want to use uuid daemon.])
-- 
2.1.4

Re: [PATCH] build: uuidd requires linux now, uses signalfd

[Ruediger Meier]

On Sunday 13 March 2016, Andreas Henriksson wrote:
> Specify that uuidd can only be built on Linux now since

Did you managed to build ipcs and ipcrm and do they work
correctly? Which system have you tried?

> commit 25d66b4e3232d7b "uuidd: use signalfd() and setup_timer()"
>
> Signed-off-by: Andreas Henriksson <andreas@fatal.se>
> ---
>  configure.ac | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/configure.ac b/configure.ac
> index 8d808b7..e5ee3fb 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1079,6 +1079,7 @@ AC_ARG_ENABLE([uuidd],
>    [], [UL_DEFAULT_ENABLE([uuidd], [check])]
>  )
>  UL_BUILD_INIT([uuidd])
> +UL_REQUIRES_LINUX([uuidd])
>  UL_REQUIRES_BUILD([uuidd], [libuuid])
>  AS_IF([test "x$build_uuidd" = xyes], [
>    AC_DEFINE([HAVE_UUIDD], [1], [Define to 1 if you want to use uuid
> daemon.])


I have an alternative patch and would push it until tomorrow:

-----------
build-sys: improve uuidd and script build conditions

diff --git a/configure.ac b/configure.ac
index 5e89e3b..fafe762 100644
--- a/configure.ac
+++ b/configure.ac
@@ -244,6 +244,7 @@ AC_CHECK_HEADERS([ \
 	sys/param.h \
 	sys/prctl.h \
 	sys/resource.h \
+	sys/signalfd.h \
 	sys/socket.h \
 	sys/sockio.h \
 	sys/stat.h \
@@ -289,6 +290,7 @@ 
have_security_pam_appl_h=$ac_cv_header_security_pam_appl_h
 have_security_pam_misc_h=$ac_cv_header_security_pam_misc_h
 have_security_openpam_h=$ac_cv_header_security_openpam_h
 have_shadow_h=$ac_cv_header_shadow_h
+have_sys_signalfd_h=$ac_cv_header_sys_signalfd_h
 have_utmp_h=$ac_cv_header_utmp_h
 
 AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
@@ -1079,6 +1081,8 @@ AC_ARG_ENABLE([uuidd],
 )
 UL_BUILD_INIT([uuidd])
 UL_REQUIRES_BUILD([uuidd], [libuuid])
+UL_REQUIRES_HAVE([uuidd], [timer], [timer_create function])
+UL_REQUIRES_HAVE([uuidd], [sys_signalfd_h], [sys/signalfd.h header])
 AS_IF([test "x$build_uuidd" = xyes], [
   AC_DEFINE([HAVE_UUIDD], [1], [Define to 1 if you want to use uuid 
daemon.])
 ])
@@ -1494,7 +1498,7 @@ UL_REQUIRES_LINUX([setarch])
 AM_CONDITIONAL([BUILD_SETARCH], [test "x$build_setarch" = xyes])
 
 UL_BUILD_INIT([script], [check])
-UL_REQUIRES_LINUX([script])
+UL_REQUIRES_HAVE([script], [sys_signalfd_h], [sys/signalfd.h header])
 AM_CONDITIONAL([BUILD_SCRIPT], [test "x$build_script" = xyes])
 
 UL_BUILD_INIT([scriptreplay], [yes])
-----------

Re: [PATCH] build: uuidd requires linux now, uses signalfd

[Andreas Henriksson]

Hello Ruediger Meier.

On Sun, Mar 13, 2016 at 09:45:44PM +0100, Ruediger Meier wrote:
> On Sunday 13 March 2016, Andreas Henriksson wrote:
> > Specify that uuidd can only be built on Linux now since
> 
> Did you managed to build ipcs and ipcrm and do they work
> correctly? Which system have you tried?

No I have not. This was simply a reaction to the immediate problems
found in the build daemon logs after uploading 2.28-rc1 to
Debian Experimental, see
https://buildd.debian.org/status/package.php?p=util-linux&suite=experimental

It's possible additional fixes are needed. I don't run non-Linux myself.

Regards,
Andreas Henriksson

Re: [PATCH] build: uuidd requires linux now, uses signalfd

[Ruediger Meier]

On Monday 14 March 2016, Andreas Henriksson wrote:
> Hello Ruediger Meier.
>
> On Sun, Mar 13, 2016 at 09:45:44PM +0100, Ruediger Meier wrote:
> > On Sunday 13 March 2016, Andreas Henriksson wrote:
> > > Specify that uuidd can only be built on Linux now since
> >
> > Did you managed to build ipcs and ipcrm and do they work
> > correctly? Which system have you tried?
>
> No I have not. This was simply a reaction to the immediate problems
> found in the build daemon logs after uploading 2.28-rc1 to
> Debian Experimental, see
> https://buildd.debian.org/status/package.php?p=util-linux&suite=exper
>imental
>

Nice build logs!
BTW since you are running the tests with --verbose you could also force
--parallel=1 to not mix output of certain tests.

> It's possible additional fixes are needed. I don't run non-Linux
> myself.

Hurd has no WEXITED:
  login-utils/sulogin.c:1073:35: error: 'WEXITED' undeclared
     ret = waitid(P_ALL, 0, &status, WEXITED);

Maybe to be fixed like this (ifdef'ed)
https://lists.debian.org/debian-hurd/2013/07/msg00046.html


And I see my old question answered regarding 565964a9.
fdisk/bsd test fails on alpha because of

libfdisk/src/bsd.c:
#ifdef __alpha__
        {BSD_FS_EXT2,   "ext2"},
#else
        {BSD_FS_MSDOS,  "MS-DOS"},
#endif

Could be simply skipped for now like this:

diff --git a/tests/ts/fdisk/bsd b/tests/ts/fdisk/bsd
index cd7a6c6..386402a 100755
--- a/tests/ts/fdisk/bsd
+++ b/tests/ts/fdisk/bsd
@@ -137,4 +137,5 @@ echo -e "${FDISK_CMD_BSD_LIST_TYPES}" | \

 fdisk_bsd_offset_and_byte_order_clean
 ts_fdisk_clean ${TEST_IMAGE_NAME}
+grep "3  Version 7        8  ext2             c  ISO-9660        10  AdvFS" $TS_OUTPUT && ts_skip "alpha undefined"
 ts_finalize


cu,
Rudi