Util-Linux package development
 help / color / mirror / Atom feed
From: Ruediger Meier <sweet_f_a@gmx.de>
To: Benno Schulenberg <bensberg@justemail.net>
Cc: "Util-Linux" <util-linux@vger.kernel.org>
Subject: Re: cancelling the tests says that they all passed
Date: Thu, 17 Mar 2016 13:50:43 +0100	[thread overview]
Message-ID: <201603171350.44094.sweet_f_a@gmx.de> (raw)
In-Reply-To: <1458215622.795504.551872786.40E5990C@webmail.messagingengine.com>

On Thursday 17 March 2016, Benno Schulenberg wrote:
> On Thu, Mar 17, 2016, at 11:35, Ruediger Meier wrote:
> > On Thursday 17 March 2016, Benno Schulenberg wrote:
> > > When one hits ^C when the compilation phase of 'make check'
> > > finishes and the first tests start executing, the script prints
> >
> > I don't manage to reproduce that. How do you run make exactly (-j)?
>
> Just plain 'make' and 'make check'.
>
> > If I hit ctrl-C during compilation then the test script does not
> > start at all. Maybe there is a dependency problem and your tests
> > start before compilation is finished?
>
> No, I don't hit ^C during compilation but when it has finished,
> when that scary warning "Don't execute on production system!"
> has been printed and the first "OK"s have appeared.
>
> > Could you show us the test diffs?
> > $ find tests/diff/ -type f | xargs -r cat
>
> Attached.
> 
> > Maybe also warnings durning the test run (if any).
>
> Only the ipcs one prints warnings:
>
>          ipcs: mk-rm-msg                                     ... OK
>          ipcs: mk-rm-sem                                     ... OK
> ipcs: id 1048595 not found
> ipcs: id 1081363 not found
>          ipcs: mk-rm-shm                                     ...
> FAILED (ipcs/mk-rm-shm)

Thanks!

I have some guesses about "ipcs" and "fallocate" but some more 
questions:

1. Which kernel version?
2. Which file system? (findmnt -n -o FSTYPE -T tests/output)
3. Is /proc mounted?
4  grep "FALL" config.h

"swaplabel" test fails because it's using again fallocate. Maybe we 
should use dd/truncate instead to not test fallocate again.

The misc/ul failure is something about different ncurses (or 
terminals?). I know it from BSD. Don't know how this should be fixed in 
our test suite because I don't know much about ncurses stuff.

This is the plain diff:

--- tests/expected/misc/ul
+++ tests/output/misc/ul
@@ -1,3 +1,3 @@
-^[[1ma^[(B^[[mb^[[4mc^[[24m
+^[[1ma^[[m^[(Bb^[[4mc^[[24m


Interpreted by terminal both looks ok: "abc" with bold "a" and 
underlined "c". I sombody confirmes that both strings in the diff are 
totally ok on any system, then I would fix the test by using sed.

cu,
Rudi

  reply	other threads:[~2016-03-17 12:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-17  9:44 cancelling the tests says that they all passed Benno Schulenberg
2016-03-17 10:35 ` Ruediger Meier
2016-03-17 11:53   ` Benno Schulenberg
2016-03-17 12:50     ` Ruediger Meier [this message]
2016-03-17 16:49       ` Benno Schulenberg
2016-03-17 17:18         ` Ruediger Meier
2016-03-17 18:23           ` Benno Schulenberg
2016-03-17 19:48             ` Ruediger Meier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201603171350.44094.sweet_f_a@gmx.de \
    --to=sweet_f_a@gmx.de \
    --cc=bensberg@justemail.net \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox