From: Ruediger Meier <sweet_f_a@gmx.de>
To: Benno Schulenberg <bensberg@justemail.net>
Cc: "Util-Linux" <util-linux@vger.kernel.org>
Subject: Re: cancelling the tests says that they all passed
Date: Thu, 17 Mar 2016 18:18:52 +0100 [thread overview]
Message-ID: <201603171818.52599.sweet_f_a@gmx.de> (raw)
In-Reply-To: <1458233386.879328.552147938.0BC34E2C@webmail.messagingengine.com>
On Thursday 17 March 2016, Benno Schulenberg wrote:
> On Thu, Mar 17, 2016, at 13:50, Ruediger Meier wrote:
> > I have some guesses about "ipcs" and "fallocate" but some more
> > questions:
> >
> > 1. Which kernel version?
>
> 2.6.32
Hehe my guess was right.
I've noticed already 2 years ago on Debian 6 that our scanf code in
ipc_shm_get_info() is not compatible to this kernel version. (2.6.34
worked AFAIR.)
Could you show us
$ cat /proc/sysvipc/shm
Maybe it's easy to fix.
Generally I think we should make a statement about "what is the minimum
kernel version" for util-linux. Two years ago I decided for myself that
I should fix bugs for newer kernels first. On the other hand 2.6.32
would have been worth to support because it was officially maintained
from 2009 until last month!
> > 2. Which file system? (findmnt -n -o FSTYPE -T tests/output)
>
> ext3
ext3 is not supported but the system call should return an error and the
test should look like this:
misc: fallocate ... SKIPPED ('ext3' not supported)
I guess the kernel syscall does not return error thus our fallocate
succeed but the file is empty. It's a kernel bug we can't fix. Or
should we add a stat() call to validate the syscall?
> > 3. Is /proc mounted?
>
> $ ./findmnt -n -t proc
> /proc none proc rw,nosuid,nodev,noexec,relatime
>
> > 4 grep "FALL" config.h
>
> #define HAVE_FALLOCATE 1
> #define HAVE_LINUX_FALLOC_H 1
>
> Benno
next prev parent reply other threads:[~2016-03-17 17:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 9:44 cancelling the tests says that they all passed Benno Schulenberg
2016-03-17 10:35 ` Ruediger Meier
2016-03-17 11:53 ` Benno Schulenberg
2016-03-17 12:50 ` Ruediger Meier
2016-03-17 16:49 ` Benno Schulenberg
2016-03-17 17:18 ` Ruediger Meier [this message]
2016-03-17 18:23 ` Benno Schulenberg
2016-03-17 19:48 ` Ruediger Meier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201603171818.52599.sweet_f_a@gmx.de \
--to=sweet_f_a@gmx.de \
--cc=bensberg@justemail.net \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox