[PATCH 1/2] build-sys: no need to un-ignore tracked files

[PATCH 1/2] build-sys: no need to un-ignore tracked files

[Ruediger Meier]

From: Ruediger Meier <ruediger.meier@ga-group.nl>

Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
---
 .gitignore | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/.gitignore b/.gitignore
index a008740..841111e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -55,16 +55,6 @@ tests/run.sh.log
 tests/run.sh.trs
 update.log
 
-# libuuid depends on AX_TLS macro
-!m4/tls.m4
-
-# GTK_DOC_CHECK depends on gtk-doc.m4
-!m4/gtk-doc.m4
-
-# util-linux specific macros
-!m4/ul.m4
-!m4/compiler.m4
-
 #
 # binaries
 #
-- 
1.8.4.5

[PATCH 2/2] build-sys: install missing bash completions

[Ruediger Meier]

From: Ruediger Meier <ruediger.meier@ga-group.nl>

We haven't installed these files since three years. Hopefully
they will work.

Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
---
 bash-completion/Makemodule.am | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/bash-completion/Makemodule.am b/bash-completion/Makemodule.am
index 56fdd32..89ae8dd 100644
--- a/bash-completion/Makemodule.am
+++ b/bash-completion/Makemodule.am
@@ -223,6 +223,10 @@ endif
 if BUILD_LOSETUP
 dist_bashcompletion_DATA += bash-completion/losetup
 endif
+if BUILD_MOUNT
+dist_bashcompletion_DATA += bash-completion/mount
+dist_bashcompletion_DATA += bash-completion/umount
+endif
 if BUILD_MOUNTPOINT
 dist_bashcompletion_DATA += bash-completion/mountpoint
 endif
@@ -237,6 +241,7 @@ dist_bashcompletion_DATA += bash-completion/setpriv
 endif
 if BUILD_SWAPON
 dist_bashcompletion_DATA += bash-completion/swapon
+dist_bashcompletion_DATA += bash-completion/swapoff
 endif
 if BUILD_UNSHARE
 dist_bashcompletion_DATA += bash-completion/unshare
-- 
1.8.4.5

Re: [PATCH 1/2] build-sys: no need to un-ignore tracked files

[Karel Zak]

On Thu, Mar 17, 2016 at 11:04:05AM +0100, Ruediger Meier wrote:
>  .gitignore | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/.gitignore b/.gitignore
> index a008740..841111e 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -55,16 +55,6 @@ tests/run.sh.log
>  tests/run.sh.trs
>  update.log
>  
> -# libuuid depends on AX_TLS macro
> -!m4/tls.m4
> -
> -# GTK_DOC_CHECK depends on gtk-doc.m4
> -!m4/gtk-doc.m4
> -
> -# util-linux specific macros
> -!m4/ul.m4
> -!m4/compiler.m4
> -

Strange, I'm almost sure this was necessary years ago.

Applied, thanks.

    Karel


-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

Re: [PATCH 2/2] build-sys: install missing bash completions

[Karel Zak]

On Thu, Mar 17, 2016 at 11:04:06AM +0100, Ruediger Meier wrote:
> From: Ruediger Meier <ruediger.meier@ga-group.nl>
> 
> We haven't installed these files since three years. Hopefully
> they will work.
> 
> Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
> ---
>  bash-completion/Makemodule.am | 5 +++++
>  1 file changed, 5 insertions(+)

 Applied, thanks.

    Karel


-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

Re: [PATCH 2/2] build-sys: install missing bash completions

[Karel Zak]

On Thu, Mar 17, 2016 at 11:04:06AM +0100, Ruediger Meier wrote:
> We haven't installed these files since three years. Hopefully
> they will work.

 I have added tools/checkcompletion.sh (sorry about my shell
 programming skills, it requires bash:-), so now:

 $ make checkcompletion 
 Missing completion scripts:
    agetty
    findfs
    kill
    line
    login
    runuser
    sulogin
    switch_root
    vipw


> +if BUILD_MOUNT
> +dist_bashcompletion_DATA += bash-completion/mount
> +dist_bashcompletion_DATA += bash-completion/umount
> +endif

 ... and checkcompletion does not check for incomplete Makefiles of
 course, but better than nothing.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

Re: [PATCH 2/2] build-sys: install missing bash completions

[Ruediger Meier]

On Thursday 17 March 2016, Karel Zak wrote:
> On Thu, Mar 17, 2016 at 11:04:06AM +0100, Ruediger Meier wrote:
> > We haven't installed these files since three years. Hopefully
> > they will work.
>
>  I have added tools/checkcompletion.sh (sorry about my shell
>  programming skills, it requires bash:-), so now:

Don't be ashamed! Just "git add" and push again ;)

Re: [PATCH 2/2] build-sys: install missing bash completions

[Karel Zak]

On Thu, Mar 17, 2016 at 02:22:31PM +0100, Ruediger Meier wrote:
> On Thursday 17 March 2016, Karel Zak wrote:
> > On Thu, Mar 17, 2016 at 11:04:06AM +0100, Ruediger Meier wrote:
> > > We haven't installed these files since three years. Hopefully
> > > they will work.
> >
> >  I have added tools/checkcompletion.sh (sorry about my shell
> >  programming skills, it requires bash:-), so now:
> 
> Don't be ashamed! Just "git add" and push again ;)

 Ah..... fixed :-)

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

Re: [PATCH 2/2] build-sys: install missing bash completions

[Ruediger Meier]

On Thursday 17 March 2016, Karel Zak wrote:
> On Thu, Mar 17, 2016 at 11:04:06AM +0100, Ruediger Meier wrote:
> > We haven't installed these files since three years. Hopefully
> > they will work.
>
>  I have added tools/checkcompletion.sh (sorry about my shell
>  programming skills, it requires bash:-), so now:
>
>  $ make checkcompletion
>  Missing completion scripts:
>     agetty
>     findfs
>     kill
>     line
>     login
>     runuser
>     sulogin
>     switch_root
>     vipw

> > +if BUILD_MOUNT
> > +dist_bashcompletion_DATA += bash-completion/mount
> > +dist_bashcompletion_DATA += bash-completion/umount
> > +endif
>
>  ... and checkcompletion does not check for incomplete Makefiles of
>  course, but better than nothing.

Maybe checkcompletion.sh would be more simple and safe if we do
"make install DESTDIR=/tmp/dest" and compare installed *bin/ binaries.
with installed completions (and BTW manpages!). It would also discover
Makefile bugs. I'm sure that such distcheck-hook scripts should
already exist. Like rpmlint does such checks for the distro packages
and prints warnings plus counts negative scores:

RPMLINT report:
===============
[...]
util-linux.x86_64: W: no-manual-page-for-binary flushb
util-linux.x86_64: W: no-manual-page-for-binary chrp-addnote
Each executable in standard binary directories should have a man page.
[...]



But actually the most simple way to find non-distributed
files in _general_ is IMO this:

$ make distdir
$ find util-linux-2.28.rc1-65-5ae7a/ -type f -printf "%P\n" | sort > files-dist
$ git ls-files | sort > files-git
$ diff files-git files-dist | grep "^<"

These are so few (or generic) currently that we could maintain a
whitelist "non-distributed-files". And add such a check to the
distcheck somehow.

cu,
Rudi

Re: [PATCH 2/2] build-sys: install missing bash completions

[Karel Zak]

On Thu, Mar 17, 2016 at 05:52:27PM +0100, Ruediger Meier wrote:
> On Thursday 17 March 2016, Karel Zak wrote:
> > On Thu, Mar 17, 2016 at 11:04:06AM +0100, Ruediger Meier wrote:
> > > We haven't installed these files since three years. Hopefully
> > > they will work.
> >
> >  I have added tools/checkcompletion.sh (sorry about my shell
> >  programming skills, it requires bash:-), so now:
> >
> >  $ make checkcompletion
> >  Missing completion scripts:
> >     agetty
> >     findfs
> >     kill
> >     line
> >     login
> >     runuser
> >     sulogin
> >     switch_root
> >     vipw
> 
> > > +if BUILD_MOUNT
> > > +dist_bashcompletion_DATA += bash-completion/mount
> > > +dist_bashcompletion_DATA += bash-completion/umount
> > > +endif
> >
> >  ... and checkcompletion does not check for incomplete Makefiles of
> >  course, but better than nothing.
> 
> Maybe checkcompletion.sh would be more simple and safe if we do
> "make install DESTDIR=/tmp/dest" and compare installed *bin/ binaries.

Good point.

> with installed completions (and BTW manpages!). It would also discover
> Makefile bugs. I'm sure that such distcheck-hook scripts should
> already exist. Like rpmlint does such checks for the distro packages
> and prints warnings plus counts negative scores:
> 
> RPMLINT report:
> ===============
> [...]
> util-linux.x86_64: W: no-manual-page-for-binary flushb
> util-linux.x86_64: W: no-manual-page-for-binary chrp-addnote
> Each executable in standard binary directories should have a man page.
> [...]
> 
> 
> 
> But actually the most simple way to find non-distributed
> files in _general_ is IMO this:
> 
> $ make distdir
> $ find util-linux-2.28.rc1-65-5ae7a/ -type f -printf "%P\n" | sort > files-dist
> $ git ls-files | sort > files-git
> $ diff files-git files-dist | grep "^<"

Well, "make distcheck" already checks if the final tarball is usable
without git tree.

I think more important is "make install" consistence, because it
absolutely without any verification. (Well, before release I always
use the new tarball for Fedora util-linux RPM, so it's verified. I
also use ./tests/ts/build-sys/config --force to see changes in the
build system.

I agree that for v2.29 it would be nice to add some "make checkxxxx"
targets based on "make install".


-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

Re: [PATCH 2/2] build-sys: install missing bash completions

[Ruediger Meier]

On Thursday 17 March 2016, Karel Zak wrote:
> On Thu, Mar 17, 2016 at 05:52:27PM +0100, Ruediger Meier wrote:
> > On Thursday 17 March 2016, Karel Zak wrote:
> > > On Thu, Mar 17, 2016 at 11:04:06AM +0100, Ruediger Meier wrote:
> > > > We haven't installed these files since three years. Hopefully
> > > > they will work.
> > >
> > >  I have added tools/checkcompletion.sh (sorry about my shell
> > >  programming skills, it requires bash:-), so now:
> > >
> > >  $ make checkcompletion
> > >  Missing completion scripts:
> > >     agetty
> > >     findfs
> > >     kill
> > >     line
> > >     login
> > >     runuser
> > >     sulogin
> > >     switch_root
> > >     vipw
> > >
> > > > +if BUILD_MOUNT
> > > > +dist_bashcompletion_DATA += bash-completion/mount
> > > > +dist_bashcompletion_DATA += bash-completion/umount
> > > > +endif
> > >
> > >  ... and checkcompletion does not check for incomplete Makefiles
> > > of course, but better than nothing.
> >
> > Maybe checkcompletion.sh would be more simple and safe if we do
> > "make install DESTDIR=/tmp/dest" and compare installed *bin/
> > binaries.
>
> Good point.
>
> > with installed completions (and BTW manpages!). It would also
> > discover Makefile bugs. I'm sure that such distcheck-hook scripts
> > should already exist. Like rpmlint does such checks for the distro
> > packages and prints warnings plus counts negative scores:
> >
> > RPMLINT report:
> > ===============
> > [...]
> > util-linux.x86_64: W: no-manual-page-for-binary flushb
> > util-linux.x86_64: W: no-manual-page-for-binary chrp-addnote
> > Each executable in standard binary directories should have a man
> > page. [...]
> >
> >
> >
> > But actually the most simple way to find non-distributed
> > files in _general_ is IMO this:
> >
> > $ make distdir
> > $ find util-linux-2.28.rc1-65-5ae7a/ -type f -printf "%P\n" | sort
> > > files-dist $ git ls-files | sort > files-git
> > $ diff files-git files-dist | grep "^<"
>
> Well, "make distcheck" already checks if the final tarball is usable
> without git tree.

Yes, but these commands above showed me clearly that somebody committed 
bash completions but we neither distribute nor install them! distcheck 
can't find such issues.

BTW I had spent almost one hour with creating very exotic 
grep/git/find/whatever command line pipes because I _wanted_ to find 
dead/unused files. Finally above stupid thing worked.

Funny that these 3 files were not installed since 3 years but 
nethertheless maintained and bug fixed a few times. This shows that I'm 
not the only one who _greps_ for bugs if you don't see any in real 
life. :)

cu,
Rudi