libmount python bindings and header includes

libmount python bindings and header includes

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

i'm currently seeing these build warnings:
libmount/python/fs.c:110:40: warning: implicit declaration of function 'major'
libmount/python/fs.c:111:7: warning: implicit declaration of function 'minor'

this is handled for most of the code in include/c.h:
#ifdef HAVE_SYS_SYSMACROS_H
# include <sys/sysmacros.h>     /* for major, minor */
#endif

but the python code doesn't include that header.  i'm not sure what the
preference is here (make the python code pull in that header or just copy
over the sysmacros.h logic), so i'm skipping writing a patch.
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: libmount python bindings and header includes

[Karel Zak]

On Tue, Apr 12, 2016 at 01:46:53PM -0400, Mike Frysinger wrote:
> i'm currently seeing these build warnings:
> libmount/python/fs.c:110:40: warning: implicit declaration of function 'major'
> libmount/python/fs.c:111:7: warning: implicit declaration of function 'minor'
> 
> this is handled for most of the code in include/c.h:
> #ifdef HAVE_SYS_SYSMACROS_H
> # include <sys/sysmacros.h>     /* for major, minor */
> #endif
> 
> but the python code doesn't include that header.  i'm not sure what the
> preference is here (make the python code pull in that header or just copy
> over the sysmacros.h logic), so i'm skipping writing a patch.

Our c.h is so wonderful that it's expected everywhere :) Fixed.

Thanks!
    Karel


-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com