From: Sami Kerola <kerolasa@iki.fi>
To: util-linux@vger.kernel.org
Cc: Sami Kerola <kerolasa@iki.fi>
Subject: [PATCH 1/3] rename: make --no-act to imply --verbose
Date: Thu, 18 May 2017 22:19:34 +0100 [thread overview]
Message-ID: <20170518211936.28153-2-kerolasa@iki.fi> (raw)
In-Reply-To: <20170518211936.28153-1-kerolasa@iki.fi>
It is reasonable to assume use of --no-act means one wants to always see
what would have happen if rename is done. To say same slightly differently,
if there is sn use case for silent rename --no-act run I cannot think one.
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---
misc-utils/rename.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/misc-utils/rename.c b/misc-utils/rename.c
index c1b9d4a0e..502e888d7 100644
--- a/misc-utils/rename.c
+++ b/misc-utils/rename.c
@@ -154,11 +154,11 @@ int main(int argc, char **argv)
while ((c = getopt_long(argc, argv, "vsVhn", longopts, NULL)) != -1)
switch (c) {
- case 'v':
- verbose = 1;
- break;
case 'n':
noact = 1;
+ /* fallthrough */
+ case 'v':
+ verbose = 1;
break;
case 's':
do_rename = do_symlink;
--
2.13.0
next prev parent reply other threads:[~2017-05-18 21:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 21:19 [PATCH 0/3] pull: rename usability and readline improvements Sami Kerola
2017-05-18 21:19 ` Sami Kerola [this message]
2017-05-18 21:19 ` [PATCH 2/3] chfn: disable tab completion Sami Kerola
2017-05-18 21:19 ` [PATCH 3/3] chsh: make readline completion to propose valid shells Sami Kerola
2017-05-19 8:26 ` Karel Zak
2017-06-05 11:36 ` Karel Zak
2017-05-19 9:44 ` [PATCH 0/3] pull: rename usability and readline improvements Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518211936.28153-2-kerolasa@iki.fi \
--to=kerolasa@iki.fi \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox