From: Karel Zak <kzak@redhat.com>
To: Sami Kerola <kerolasa@iki.fi>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 3/3] chsh: make readline completion to propose valid shells
Date: Fri, 19 May 2017 10:26:18 +0200 [thread overview]
Message-ID: <20170519082618.7karkcbuugicnmvx@ws.net.home> (raw)
In-Reply-To: <20170518211936.28153-4-kerolasa@iki.fi>
On Thu, May 18, 2017 at 10:19:36PM +0100, Sami Kerola wrote:
> This is better than default readline completion, that gives paths from
> current directory onwards.
>
> Signed-off-by: Sami Kerola <kerolasa@iki.fi>
> ---
> login-utils/chsh.c | 117 ++++++++++++++++++++++++++++++++++++++++-------------
> 1 file changed, 90 insertions(+), 27 deletions(-)
Not sure with this patch, seems too invasive for rc2. Let's wait for v2.31
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2017-05-19 8:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 21:19 [PATCH 0/3] pull: rename usability and readline improvements Sami Kerola
2017-05-18 21:19 ` [PATCH 1/3] rename: make --no-act to imply --verbose Sami Kerola
2017-05-18 21:19 ` [PATCH 2/3] chfn: disable tab completion Sami Kerola
2017-05-18 21:19 ` [PATCH 3/3] chsh: make readline completion to propose valid shells Sami Kerola
2017-05-19 8:26 ` Karel Zak [this message]
2017-06-05 11:36 ` Karel Zak
2017-05-19 9:44 ` [PATCH 0/3] pull: rename usability and readline improvements Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170519082618.7karkcbuugicnmvx@ws.net.home \
--to=kzak@redhat.com \
--cc=kerolasa@iki.fi \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox