[PATCH] bash-completion: make sure that "lastb" actually completes

[PATCH] bash-completion: make sure that "lastb" actually completes

[Eli Schwartz]

Building util-linux logs a warning on Gentoo:

```
 * Problems with installed bash completions were found:
 *
 * 	lastb: incorrect name, no completions for 'lastb' command defined.
 *
 * For more details on installing bash-completions, please see:
 * https://wiki.gentoo.org/wiki/Bash/Installing_completion_files
```

A bash-completion file is usually composed of two parts:
- a function that knows how to produce completions
- a specification of which command should be completed

In cases where multiple commands have the same options, e.g. commands
that are symlinked to each other, it is common to symlink the completion
files as well. This shares the first part. But the second part cannot be
shared, it must be implemented twice by specifying two different
commands to be completed.

"lastb" had a symlinked completion, but when the completion system
processes /usr/share/bash-completion/completions/lastb, it would only
define a completion for "last".

Define both completions in one file, so that sourcing it works
regardless of command used.
---
 bash-completion/last | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bash-completion/last b/bash-completion/last
index 180d9a94b..ff264c1d2 100644
--- a/bash-completion/last
+++ b/bash-completion/last
@@ -51,4 +51,4 @@ _last_module()
 	COMPREPLY=( $(compgen -u -- $cur) )
 	return 0
 }
-complete -F _last_module last
+complete -F _last_module last lastb
-- 
2.41.0

Re: [PATCH] bash-completion: make sure that "lastb" actually completes

[Karel Zak]

On Wed, Dec 06, 2023 at 07:40:44PM -0500, Eli Schwartz wrote:
>  bash-completion/last | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com