* [PATCH] Mount: fix recursively propagation mounting
@ 2012-03-21 9:15 don
2012-03-21 10:07 ` Voelker, Bernhard
2012-03-21 11:38 ` Karel Zak
0 siblings, 2 replies; 3+ messages in thread
From: don @ 2012-03-21 9:15 UTC (permalink / raw)
To: util-linux
From: Dong Hao <haodong@linux.vnet.ibm.com>
Date: Wed, 21 Mar 2012 13:50:14 +0800
Subject: [PATCH] Mount: fix recursively propagation mounting
Provide the recursive flag of propagation mounting. Recursive flag could
be used together with propagation flag.
Signed-off-by: Dong Hao <haodong@linux.vnet.ibm.com>
---
mount/mount.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mount/mount.c b/mount/mount.c
index 2ce4829..f10659c 100644
--- a/mount/mount.c
+++ b/mount/mount.c
@@ -603,7 +603,7 @@ parse_opts (const char *options, int *flags, char
**extra_opts) {
/* The propagation flags should not be used together with any
other flags */
if (*flags & MS_PROPAGATION)
- *flags &= MS_PROPAGATION;
+ *flags &= (MS_PROPAGATION|MS_REC);
}
/* Try to build a canonical options string. */
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] Mount: fix recursively propagation mounting
2012-03-21 9:15 [PATCH] Mount: fix recursively propagation mounting don
@ 2012-03-21 10:07 ` Voelker, Bernhard
2012-03-21 11:38 ` Karel Zak
1 sibling, 0 replies; 3+ messages in thread
From: Voelker, Bernhard @ 2012-03-21 10:07 UTC (permalink / raw)
To: don, util-linux@vger.kernel.org
don wrote:
> From: Dong Hao <haodong@linux.vnet.ibm.com>
> Date: Wed, 21 Mar 2012 13:50:14 +0800
> Subject: [PATCH] Mount: fix recursively propagation mounting
>
> Provide the recursive flag of propagation mounting. Recursive flag could
> be used together with propagation flag.
>
> Signed-off-by: Dong Hao <haodong@linux.vnet.ibm.com>
> ---
> mount/mount.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/mount/mount.c b/mount/mount.c
> index 2ce4829..f10659c 100644
> --- a/mount/mount.c
> +++ b/mount/mount.c
> @@ -603,7 +603,7 @@ parse_opts (const char *options, int *flags, char
> **extra_opts) {
>
> /* The propagation flags should not be used together with any
> other flags */
> if (*flags & MS_PROPAGATION)
> - *flags &= MS_PROPAGATION;
> + *flags &= (MS_PROPAGATION|MS_REC);
> }
>
> /* Try to build a canonical options string. */
> --
> 1.7.2.5
The comment above conflicts with the change.
Shouldn't it be also adapted?
Have a nice day,
Berny
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Mount: fix recursively propagation mounting
2012-03-21 9:15 [PATCH] Mount: fix recursively propagation mounting don
2012-03-21 10:07 ` Voelker, Bernhard
@ 2012-03-21 11:38 ` Karel Zak
1 sibling, 0 replies; 3+ messages in thread
From: Karel Zak @ 2012-03-21 11:38 UTC (permalink / raw)
To: don; +Cc: util-linux
On Wed, Mar 21, 2012 at 05:15:48PM +0800, don wrote:
> mount/mount.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied, thanks.
I have also added MS_SILENT to the acceptable flags and fixed the new
mount code in libmount.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-21 11:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-21 9:15 [PATCH] Mount: fix recursively propagation mounting don
2012-03-21 10:07 ` Voelker, Bernhard
2012-03-21 11:38 ` Karel Zak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox