Re: [PATCH] libmount: handle btrfs default subvolume mount

[Stanislav Brabec <sbrabec@suse.cz>]

Karel Zak wrote:
> On Wed, Jan 20, 2016 at 10:57:07PM +0100, Stanislav Brabec wrote:
>> +/**
>> + * btrfs_get_default_subvol_id:
>> + * @path: Path to mounted btrfs volume
>
> this comment formatting indicate API docs, for private library functions
> we don't use "/**".
>
Should I export this? I think that no.

Well, looking again into libbtrfs, it is also possible to use
btrfs_list_get_default_subvolume() from libbtrfs, as is nearly exactly 
the same. But I am not sure, whether it is good to introduce such a
dependency just for a single small function.

P. S.:

David also wrote btrfs_get_default_subvolume_path(), but then we found,
that there is probably better to use subvolid and path saved in
procinfo:

+ The tab.c patch would be much smaller and straightforward.
- Kernel evaluates it when creating procinfo entries, this would
   duplicate it.
x Both subvol and subvolid in procinfo were introduced together in the
   mainline kernel, and btrfs_get_default_subvolume_path() needs more
   ioctl() calls.

-- 
Best Regards / S pozdravem,

Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o.                         e-mail: sbrabec@suse.com
Lihovarská 1060/12                            tel: +49 911 7405384547
190 00 Praha 9                                 fax:  +420 284 084 001
Czech Republic                                    http://www.suse.cz/
PGP: 830B 40D5 9E05 35D8 5E27 6FA3 717C 209F A04F CD76