From: Stanislav Brabec <sbrabec@suse.cz>
To: Ruediger Meier <sweet_f_a@gmx.de>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] tests: add test for loop option in fstab
Date: Fri, 12 Feb 2016 16:55:49 +0100 [thread overview]
Message-ID: <56BE0085.1090004@suse.cz> (raw)
In-Reply-To: <201602121628.19968.sweet_f_a@gmx.de>
Ruediger Meier wrote:
> On Thursday 11 February 2016, Stanislav Brabec wrote:
>> Add a new fstab tests which check loop mount of the same source
>> multiple times in multiple steps.
>>
>> The test is currently failing, but it should not fail once the
>> triggering bug will be fixed.
>
> Will this be fixed quickly? Otherwise we should add
> TS_KNOWN_FAIL="yes"
> to the test. Then you would still see it in the build log and test diff
> but it wouldn't bother you with build error.
This statement was valid in the time of sending the patch. Karel
promptly fixed it, so the fix appeared in the main tree even one commit
earlier:
https://git.kernel.org/cgit/utils/util-linux/util-linux.git/commit/?id=d58b9706ed8a10cc484835119ed10385d141eb6c
But there is a chance, that some tests were broken (or fixed) by
https://git.kernel.org/cgit/utils/util-linux/util-linux.git/commit/?id=b59c3bf292269be1a203f91563b961e0062e0a5f
Fix would consist of:
If there is any _expected_ message in stderr, add it to expected/.
If there is any _unexpected_ message in stderr, it means, that the test
falsely succeeded in past.
--
Best Regards / S pozdravem,
Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o. e-mail: sbrabec@suse.com
Lihovarská 1060/12 tel: +49 911 7405384547
190 00 Praha 9 fax: +420 284 084 001
Czech Republic http://www.suse.cz/
PGP: 830B 40D5 9E05 35D8 5E27 6FA3 717C 209F A04F CD76
next prev parent reply other threads:[~2016-02-12 15:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 19:45 [PATCH] tests: add test for loop option in fstab Stanislav Brabec
2016-02-12 10:10 ` Karel Zak
2016-02-12 15:28 ` Ruediger Meier
2016-02-12 15:55 ` Stanislav Brabec [this message]
2016-02-15 11:42 ` Ruediger Meier
2016-02-16 14:49 ` Karel Zak
2016-02-19 18:27 ` Stanislav Brabec
2016-02-22 10:12 ` Karel Zak
2016-02-22 10:29 ` Ruediger Meier
2016-02-22 10:53 ` Karel Zak
2016-02-22 16:36 ` Stanislav Brabec
2016-02-24 18:58 ` Stanislav Brabec
2016-02-24 21:33 ` [PATCH] tests: add test for loop option in fstab (my mistake, and two new bugs, one in kernel) Stanislav Brabec
2016-02-25 19:31 ` Stanislav Brabec
2016-03-01 15:26 ` Stanislav Brabec
-- strict thread matches above, loose matches on Subject: below --
2016-02-12 16:23 [PATCH] tests: add test for loop option in fstab Ruediger Meier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BE0085.1090004@suse.cz \
--to=sbrabec@suse.cz \
--cc=sweet_f_a@gmx.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox