Util-Linux package development
 help / color / mirror / Atom feed
* [PATCH] tests: add test for loop option in fstab
@ 2016-02-11 19:45 Stanislav Brabec
  2016-02-12 10:10 ` Karel Zak
                   ` (2 more replies)
  0 siblings, 3 replies; 16+ messages in thread
From: Stanislav Brabec @ 2016-02-11 19:45 UTC (permalink / raw)
  To: util-linux

Add a new fstab tests which check loop mount of the same source multiple times
in multiple steps.

The test is currently failing, but it should not fail once the triggering bug
will be fixed.

Signed-off-by: Stanislav Brabec <sbrabec@suse.cz>
---
 tests/expected/mount/fstab-loop |  1 +
 tests/ts/mount/fstab-loop       | 51 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 52 insertions(+)
 create mode 100644 tests/expected/mount/fstab-loop
 create mode 100755 tests/ts/mount/fstab-loop

diff --git a/tests/expected/mount/fstab-loop b/tests/expected/mount/fstab-loop
new file mode 100644
index 0000000..3582111
--- /dev/null
+++ b/tests/expected/mount/fstab-loop
@@ -0,0 +1 @@
+Success
diff --git a/tests/ts/mount/fstab-loop b/tests/ts/mount/fstab-loop
new file mode 100755
index 0000000..3178b95
--- /dev/null
+++ b/tests/ts/mount/fstab-loop
@@ -0,0 +1,51 @@
+#!/bin/bash
+
+#
+# Copyright (C) 2016 Stanislav Brabec <sbrabec@suse.cz>
+#
+# This file is part of util-linux.
+#
+# This file is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This file is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+TS_TOPDIR="${0%/*}/../.."
+TS_DESC="loop (fstab)"
+
+. $TS_TOPDIR/functions.sh
+ts_init "$*"
+
+ts_check_test_command "$TS_CMD_MOUNT"
+ts_check_test_command "$TS_CMD_UMOUNT"
+
+ts_skip_nonroot
+ts_check_losetup
+ts_check_prog "mkfs.ext3"
+
+IMG=$(ts_image_init)
+
+mkfs.ext3 $IMG &> /dev/null || ts_die "Cannot make ext3 on $DEVICE"
+
+[ -d "$TS_MOUNTPOINT-1" ] || mkdir -p $TS_MOUNTPOINT-1
+[ -d "$TS_MOUNTPOINT-2" ] || mkdir -p $TS_MOUNTPOINT-2
+
+ts_fstab_add "$IMG" "$TS_MOUNTPOINT-1" "ext3" "loop"
+$TS_CMD_MOUNT -a >> $TS_OUTPUT 2>&1
+
+ts_fstab_add "$IMG" "$TS_MOUNTPOINT-2" "ext3" "loop"
+$TS_CMD_MOUNT -a >> $TS_OUTPUT 2>&1
+
+$TS_CMD_UMOUNT "$TS_MOUNTPOINT-1" >> $TS_OUTPUT 2>&1
+$TS_CMD_UMOUNT "$TS_MOUNTPOINT-2" >> $TS_OUTPUT 2>&1
+
+ts_fstab_clean
+
+ts_log "Success"
+ts_finalize
+
-- 
2.7.0

-- 
Best Regards / S pozdravem,

Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o.                         e-mail: sbrabec@suse.com
Lihovarská 1060/12                            tel: +49 911 7405384547
190 00 Praha 9                                 fax:  +420 284 084 001
Czech Republic                                    http://www.suse.cz/
PGP: 830B 40D5 9E05 35D8 5E27 6FA3 717C 209F A04F CD76

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* Re: [PATCH] tests: add test for loop option in fstab
@ 2016-02-12 16:23 Ruediger Meier
  0 siblings, 0 replies; 16+ messages in thread
From: Ruediger Meier @ 2016-02-12 16:23 UTC (permalink / raw)
  To: util-linux

On Friday 12 February 2016 at 16:55, you wrote:
> Ruediger Meier wrote:
> > On Thursday 11 February 2016, Stanislav Brabec wrote:
> >> Add a new fstab tests which check loop mount of the same source
> >> multiple times in multiple steps.
> >>
> >> The test is currently failing, but it should not fail once the
> >> triggering bug will be fixed.
> >
> > Will this be fixed quickly? Otherwise we should add
> >    TS_KNOWN_FAIL="yes"
> > to the test. Then you would still see it in the build log and test
> > diff but it wouldn't bother you with build error.
>
> This statement was valid in the time of sending the patch. Karel
> promptly fixed it, so the fix appeared in the main tree even one
> commit earlier:

Ah sorry I've missed that. The test fails for me because of another 
minor problem. I'll send a patch.

cu,
Rudi

^ permalink raw reply	[flat|nested] 16+ messages in thread
end of thread, other threads:[~2016-03-01 15:26 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-11 19:45 [PATCH] tests: add test for loop option in fstab Stanislav Brabec
2016-02-12 10:10 ` Karel Zak
2016-02-12 15:28 ` Ruediger Meier
2016-02-12 15:55   ` Stanislav Brabec
2016-02-15 11:42 ` Ruediger Meier
2016-02-16 14:49   ` Karel Zak
2016-02-19 18:27     ` Stanislav Brabec
2016-02-22 10:12       ` Karel Zak
2016-02-22 10:29         ` Ruediger Meier
2016-02-22 10:53           ` Karel Zak
2016-02-22 16:36         ` Stanislav Brabec
2016-02-24 18:58           ` Stanislav Brabec
2016-02-24 21:33             ` [PATCH] tests: add test for loop option in fstab (my mistake, and two new bugs, one in kernel) Stanislav Brabec
2016-02-25 19:31               ` Stanislav Brabec
2016-03-01 15:26                 ` Stanislav Brabec
  -- strict thread matches above, loose matches on Subject: below --
2016-02-12 16:23 [PATCH] tests: add test for loop option in fstab Ruediger Meier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox