From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: virtio-comment@lists.oasis-open.org
Subject: Re: [virtio-comment] Re: [PATCH 3/3] shared memory: Define mmio registers
Date: Wed, 13 Feb 2019 16:52:30 +0000 [thread overview]
Message-ID: <20190213165230.GE2601@work-vm> (raw)
In-Reply-To: <20190213023352.GD14307@stefanha-x1.localdomain>
* Stefan Hajnoczi (stefanha@redhat.com) wrote:
> On Fri, Jan 11, 2019 at 11:42:00AM +0000, Dr. David Alan Gilbert (git) wrote:
> > diff --git a/content.tex b/content.tex
> > index 776162a..e2435ff 100644
> > --- a/content.tex
> > +++ b/content.tex
> > @@ -1641,6 +1641,33 @@ All register values are organized as Little Endian.
> > selected by writing to \field{QueueSel}.
> > }
> > \hline
> > + \mmioreg{SHMSel}{Shared memory region select}{0x0b0}{W}{%
> > + Writing to this register selects the shared memory region \ref{sec:Basic Facilities of a Virtio Device / Shared Memory Regions}
> > + following operations on \field{SHMId}, \field{SHMLenLow}, \field{SHMLenHigh},
> > + \field{SHMBaseLow} and \field{SHMBaseHigh} apply to. The index
> > + number of the first region is zero (0x0); note that it is a
> > + simple index that does not correspond to the \field{id}.
>
> Why use a separate virtio-mmio index instead of the shared memory ID?
> The driver would map those IDs it knows about, so I'm not sure if
> enumerating them via a separate index is useful. Plus using the ID lets
> you drop one register from the interface.
Yes, I think if we don't need enumeration that's right; we just shange
SHMId to be the writeable register and drop the SHMSel register.
Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
prev parent reply other threads:[~2019-02-13 16:52 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 11:41 [virtio-comment] [PATCH 0/3] Large shared memory regions Dr. David Alan Gilbert (git)
2019-01-11 11:41 ` [virtio-comment] [PATCH 1/3] shared memory: Define " Dr. David Alan Gilbert (git)
2019-01-11 12:15 ` Cornelia Huck
2019-01-11 12:26 ` Dr. David Alan Gilbert
2019-01-15 10:10 ` Cornelia Huck
2019-01-15 11:23 ` Dr. David Alan Gilbert
2019-01-16 10:56 ` Cornelia Huck
2019-01-16 20:06 ` Dr. David Alan Gilbert
2019-02-11 21:52 ` Cornelia Huck
2019-02-13 18:37 ` Dr. David Alan Gilbert
2019-02-14 10:58 ` Cornelia Huck
2019-02-14 16:37 ` Dr. David Alan Gilbert
2019-02-14 17:43 ` Frank Yang
2019-02-15 11:07 ` Cornelia Huck
2019-02-15 11:19 ` Dr. David Alan Gilbert
2019-02-15 12:31 ` Cornelia Huck
2019-02-18 15:28 ` Halil Pasic
2019-02-15 11:26 ` David Hildenbrand
2019-02-15 12:28 ` Cornelia Huck
2019-02-15 12:33 ` David Hildenbrand
2019-02-15 12:37 ` Cornelia Huck
2019-02-15 12:59 ` David Hildenbrand
2019-02-15 13:50 ` Dr. David Alan Gilbert
2019-02-15 13:56 ` David Hildenbrand
2019-02-15 14:02 ` Dr. David Alan Gilbert
2019-02-15 14:13 ` David Hildenbrand
2019-02-15 15:14 ` Dr. David Alan Gilbert
2019-02-15 21:42 ` Halil Pasic
2019-02-15 22:08 ` David Hildenbrand
2019-02-15 12:51 ` Halil Pasic
2019-02-15 13:33 ` Cornelia Huck
2019-01-23 15:12 ` Michael S. Tsirkin
2019-01-11 15:29 ` Halil Pasic
2019-01-11 16:07 ` Dr. David Alan Gilbert
2019-01-11 17:57 ` Halil Pasic
2019-01-15 9:33 ` Cornelia Huck
2019-02-13 2:25 ` [virtio-comment] " Stefan Hajnoczi
2019-02-13 10:44 ` Dr. David Alan Gilbert
2019-02-14 3:43 ` Stefan Hajnoczi
2019-01-11 11:41 ` [virtio-comment] [PATCH 2/3] shared memory: Define PCI capability Dr. David Alan Gilbert (git)
2019-02-13 2:30 ` [virtio-comment] " Stefan Hajnoczi
2019-01-11 11:42 ` [virtio-comment] [PATCH 3/3] shared memory: Define mmio registers Dr. David Alan Gilbert (git)
2019-02-13 2:33 ` [virtio-comment] " Stefan Hajnoczi
2019-02-13 16:52 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213165230.GE2601@work-vm \
--to=dgilbert@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtio-comment@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox