Re: [virtio-comment] [PATCH] virtio-net: add missing articles for new hdr_len feature

["Michael S. Tsirkin" <mst@redhat.com>]

On Wed, Nov 20, 2019 at 11:10:23AM +0000, Stefan Hajnoczi wrote:
> On Wed, Nov 20, 2019 at 09:29:41AM +0100, Cornelia Huck wrote:
> > Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> > ---
> > 
> > Note: I have not added definite articles to the feature description; _all_
> > features for virtio-net are described in that way, and we should add them
> > in one go should we decide to change that.
> > 
> > ---
> >  content.tex | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/content.tex b/content.tex
> > index 5d3f865956aa..452763bbbbc4 100644
> > --- a/content.tex
> > +++ b/content.tex
> > @@ -3100,8 +3100,8 @@ \subsubsection{Packet Transmission}\label{sec:Device Types / Network Device / De
> >    \begin{itemize}
> >    \item If the VIRTIO_NET_F_GUEST_HDRLEN feature has been negotiated,
> >      \field{hdr_len} indicates the header length that needs to be replicated
> > -    for each packet. It's a number of bytes from beginning of the packet
> > -    to beginning of the transport payload.
> > +    for each packet. It's a number of bytes from the beginning of the packet
> > +    to the beginning of the transport payload.
> 
> Another opportunity to tweak the text:
> s/a number of bytes/the number of bytes/ is slightly clearer
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Post a patch? Or are you asking Cornelia to integrate that into hers?


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/