Discussion of the VIRTIO specification
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: virtio-comment@lists.oasis-open.org
Cc: Vitaly Mireyno <vmireyno@marvell.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>
Subject: [virtio-comment] [PATCH] virtio-net: add missing articles for new hdr_len feature
Date: Wed, 20 Nov 2019 09:29:41 +0100	[thread overview]
Message-ID: <20191120082941.31561-1-cohuck@redhat.com> (raw)

Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---

Note: I have not added definite articles to the feature description; _all_
features for virtio-net are described in that way, and we should add them
in one go should we decide to change that.

---
 content.tex | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/content.tex b/content.tex
index 5d3f865956aa..452763bbbbc4 100644
--- a/content.tex
+++ b/content.tex
@@ -3100,8 +3100,8 @@ \subsubsection{Packet Transmission}\label{sec:Device Types / Network Device / De
   \begin{itemize}
   \item If the VIRTIO_NET_F_GUEST_HDRLEN feature has been negotiated,
     \field{hdr_len} indicates the header length that needs to be replicated
-    for each packet. It's a number of bytes from beginning of the packet
-    to beginning of the transport payload.
+    for each packet. It's a number of bytes from the beginning of the packet
+    to the beginning of the transport payload.
     Otherwise, if the VIRTIO_NET_F_GUEST_HDRLEN feature has not been negotiated,
     \field{hdr_len} is a hint to the device as to how much of the header
     needs to be kept to copy into each packet, usually set to the
@@ -3217,7 +3217,7 @@ \subsubsection{Packet Transmission}\label{sec:Device Types / Network Device / De
 
 	\begin{note}
 	Caution should be taken by the implementation so as to prevent
-	malicious driver from attacking the device by setting incorrect hdr_len.
+	a malicious driver from attacking the device by setting an incorrect hdr_len.
 	\end{note}
 
 \item If the VIRTIO_NET_F_GUEST_HDRLEN feature has not been negotiated,
-- 
2.21.0


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


             reply	other threads:[~2019-11-20  8:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-20  8:29 Cornelia Huck [this message]
2019-11-20 11:10 ` [virtio-comment] [PATCH] virtio-net: add missing articles for new hdr_len feature Stefan Hajnoczi
2019-11-20 11:16   ` Michael S. Tsirkin
2019-11-20 13:19     ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191120082941.31561-1-cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=vmireyno@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox