Discussion of the VIRTIO specification
 help / color / mirror / Atom feed
* Re: [virtio] [PATCH] pci: strengthen requirement of the correct subsystem id
       [not found] <20191028161240.24806-1-mst@redhat.com>
@ 2019-11-24 12:29 ` Michael S. Tsirkin
  0 siblings, 0 replies; only message in thread
From: Michael S. Tsirkin @ 2019-11-24 12:29 UTC (permalink / raw)
  To: virtio-comment, virtio-dev; +Cc: virtio

On Mon, Oct 28, 2019 at 12:12:49PM -0400, Michael S. Tsirkin wrote:
> If a hardware implementation of virtio does not have
> the correct subsystem id, then drivers can't report
> ir properly, or detect and work around bugs.
> Change the requirement from MAY to SHOULD.
> 
> We can't make it a MUST since we did not require this
> historically.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/61

> ---
>  content.tex | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/content.tex b/content.tex
> index 4bcb728..8f1518c 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -562,7 +562,7 @@ \subsection{PCI Device Discovery}\label{sec:Virtio Transport Options / Virtio Ov
>  For example, the network card device with the Virtio Device ID 1
>  has the PCI Device ID 0x1041 or the Transitional PCI Device ID 0x1000.
>  
> -The PCI Subsystem Vendor ID and the PCI Subsystem Device ID MAY reflect
> +The PCI Subsystem Vendor ID and the PCI Subsystem Device ID SHOULD reflect
>  the PCI Vendor and Device ID of the environment (for informational purposes by the driver).
>  
>  Non-transitional devices SHOULD have a PCI Device ID in the range
> -- 
> MST
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe from this mail list, you must leave the OASIS TC that
> generates this mail.  Follow this link to all your TCs in OASIS at:
> https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php


---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that 
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php 


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-11-24 12:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20191028161240.24806-1-mst@redhat.com>
2019-11-24 12:29 ` [virtio] [PATCH] pci: strengthen requirement of the correct subsystem id Michael S. Tsirkin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox