Discussion of the VIRTIO specification
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Yuri Benditovich <yuri.benditovich@daynix.com>
Cc: virtio-comment@lists.oasis-open.org
Subject: [virtio-comment] Re: [PATCH] virtio-net: (spelling only) support for receive-side scaling
Date: Sun, 20 Feb 2022 08:23:26 -0500	[thread overview]
Message-ID: <20220220081428-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20191125183430.1686620-1-yuri.benditovich@daynix.com>

On Mon, Nov 25, 2019 at 08:34:30PM +0200, Yuri Benditovich wrote:
> Additional patch for previous 'v4 virtio-net: define support for
> receive-side scaling' - contains only spelling fixes.
> 
> Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>

I just noticed that description of Device Initialization has not been
updated with this patch.

For example:

\item Identify and initialize the receive and
  transmission virtqueues, up to N of each kind. If
  VIRTIO_NET_F_MQ feature bit is negotiated,
  N=\field{max_virtqueue_pairs}, otherwise identify N=1.

\item If the VIRTIO_NET_F_CTRL_VQ feature bit is negotiated,
  identify the control virtqueue.

\item Fill the receive queues with buffers: see \ref{sec:Device Types / Network Device / Device Operation / Setting Up Receive Buffers}.

\item Even with VIRTIO_NET_F_MQ, only receiveq1, transmitq1 and
  controlq are used by default.  The driver would send the
  VIRTIO_NET_CTRL_MQ_VQ_PAIRS_SET command specifying the
  number of the transmit and receive queues to use.


there are some more instances of this.

I created https://github.com/oasis-tcs/virtio-spec/issues/135
to track this.
Also, https://github.com/oasis-tcs/virtio-spec/issues/134 since
VIRTIO_NET_F_MQ name is now confusing.


Yuri, could you try to address these?

Thanks!

-- 
MST


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


  parent reply	other threads:[~2022-02-20 13:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-25 18:34 [virtio-comment] [PATCH] virtio-net: (spelling only) support for receive-side scaling Yuri Benditovich
2019-11-27  9:33 ` Cornelia Huck
2022-02-20 13:23 ` Michael S. Tsirkin [this message]
2022-02-22 10:24   ` [virtio-comment] " Yuri Benditovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220220081428-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=yuri.benditovich@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox