Re: [PATCH V7] virtio-transport: Add a new section to clarify transport requirements

["Michael S. Tsirkin" <mst@redhat.com>]

On Thu, Jul 25, 2024 at 04:25:24PM +0530, Viresh Kumar wrote:
> On 25-07-24, 05:28, Michael S. Tsirkin wrote:
> > On Thu, Jul 25, 2024 at 02:45:44PM +0530, Viresh Kumar wrote:
> > > "A transport provides a mechanism for the device to communicate virtqueue
> > > configurations and memory location to the driver."
> > 
> > not really, it's normally the driver that communicates all this.
> 
> Ah.
> 
> > and configuration is it's own plural I think.
> 
> Hmm, Wikipedia [1] and chatgpt say otherwise.
> 
> Anyway, "configuration" is fine here.

The configuration as used here is its own plural.
Here's an explanation if you want the detail - not
because a random website is an expert but just because it
happens to be right.

https://www.wordhippo.com/what-is/the-plural-of/configuration.html

> > > > > The number of virtqueues per pair are governed by the individual
> > > > > +device protocol.
> > > > 
> > > > what is device protocol?
> > > 
> > > "The number of virtqueues are governed by the device implementation."
> > 
> > what are you trying to say? that transport does not need to
> > specify this?
> > basically we can just kill this sentence then?
> 
> Hmm, from what I understand the individual device implementation (protocol as
> specified in the virtio-specification, for example I2C, SPI, etc.) specify the
> exact number of virtqueues that are required for their working. I am not sure
> how a transport changes that.

No it's an i2c device, not i2c protocol. The i2c, spi etc protocols are
outside of virtio spec and have nothing to do with virtqueues.

> 
> Please suggest how you think this must be written then.

I still don't know what you want to say.
Virtio spec just calls them "specific devices".
Are you trying to say:
	The number of virtqueues is device specific and not specified by the
	transport.

> > pls check what we say about device and driver notifications and follow
> > that terminology
> 
> "A transport provides a mechanism for the device to send the configuration
> change notifications and used buffer notifications to the driver."
> 
> "A transport provides a mechanism for the driver to send the available buffer
> notifications to the device."


you can just say "device notifications" and "driver notifications",
respectively, there might be more down the road.

> 
> -- 
> viresh
> 
> [1] https://en.wiktionary.org/wiki/configuration