Re: [PATCH V7] virtio-transport: Add a new section to clarify transport requirements

[Cornelia Huck <cohuck@redhat.com>]

On Thu, Jul 11 2024, "Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Thu, Jul 11, 2024 at 01:46:19PM +0200, Cornelia Huck wrote:
>> On Thu, Jul 11 2024, "Michael S. Tsirkin" <mst@redhat.com> wrote:
>> 
>> > On Thu, Jul 11, 2024 at 01:18:18PM +0530, Viresh Kumar wrote:
>> >> The virtio documentation currently doesn't define any generic
>> >> requirements that are applicable to all transports. They can be useful
>> >> while adding support for a new transport.
>> >> 
>> >> This commit tries to define the same under a new Appendix section.
>> >> 
>> >> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>> >> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>> >> ---
>> >
>> > I am not sure what is this supposed doing - just listing basic things
>> > transport does or all things it can do?
>> >
>> > If the later, this ignores several things that transports can do,
>> > such as shared memory, data in notification, etc.
>> 
>> Maybe split this up?
>> 
>> A transport needs to implement the following:
>> <list of mandatory things>
>> 
>> A transport is encouraged to implement the following:
>> <list of non-mandatory, but strongly suggested things>
>
> Some things just depend on feature bits, and a transport
> can make a feature bit mandatory if it wants to.

I wasn't thinking about mandatory for a device/driver, but mandatory for
a transport (e.g. stuff like per-queue reset which is not mandatory for
a transport to implement.)