Discussion of the VIRTIO specification
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Cornelia Huck <cohuck@redhat.com>
Cc: virtio-comment@lists.oasis-open.org, maxim.uvarov@linaro.org,
	joakim.bech@linaro.org, ulf.hansson@linaro.org,
	ilias.apalodimas@linaro.org, arnd@linaro.org,
	ruchika.gupta@linaro.org, tomas.winkler@intel.com,
	yang.huang@intel.com, bing.zhu@intel.com,
	Matti.Moell@opensynergy.com, hmo@opensynergy.com
Subject: Re: [virtio-comment] [PATCH] virtio-rpmb: fix the description for multi-block reads
Date: Mon, 02 Aug 2021 08:09:42 +0100	[thread overview]
Message-ID: <87y29kgw3i.fsf@linaro.org> (raw)
In-Reply-To: <87czr34v66.fsf@redhat.com>


Cornelia Huck <cohuck@redhat.com> writes:

> On Thu, Jul 22 2021, Alex Bennée <alex.bennee@linaro.org> wrote:
>
>> Previously the text said we fail if block count is set to 1 despite
>> language elsewhere in the text referring to:
>>
>>   "For RPMB read request, one virtio buffer including request command
>>   and the subsequent [block_count] virtio buffers for response data
>>   are placed in the queue."
>>
>> and the existence of both max_wr_cnt and max_rd_cnt configuration
>> variables certainly implying devices should be able to handle
>> multi-block reads just like writes.
>>
>> Fix the description as well as format the steps as an enumerated list
>> to match the style of the previous section describing write handling.
>>
>> Reported-by: Ruchika Gupta <ruchika.gupta@linaro.org>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>>  virtio-rpmb.tex | 24 +++++++++++++-----------
>>  1 file changed, 13 insertions(+), 11 deletions(-)
>
> Do you want to request a vote for this?

Sure - I think it's a clarification rather than a "new" feature but
whatever is needed to get it merged ;-)

-- 
Alex Bennée


  reply	other threads:[~2021-08-02  7:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22 11:09 [virtio-comment] [PATCH] virtio-rpmb: fix the description for multi-block reads Alex Bennée
2021-07-23  0:49 ` [virtio-comment] " Huang, Yang
2021-07-27 15:45 ` [virtio-comment] " Cornelia Huck
2021-08-02  7:09   ` Alex Bennée [this message]
2021-08-02  8:25     ` Cornelia Huck
2021-08-03 15:38       ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y29kgw3i.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=Matti.Moell@opensynergy.com \
    --cc=arnd@linaro.org \
    --cc=bing.zhu@intel.com \
    --cc=cohuck@redhat.com \
    --cc=hmo@opensynergy.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=joakim.bech@linaro.org \
    --cc=maxim.uvarov@linaro.org \
    --cc=ruchika.gupta@linaro.org \
    --cc=tomas.winkler@intel.com \
    --cc=ulf.hansson@linaro.org \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=yang.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox