From: Halil Pasic <pasic@linux.vnet.ibm.com>
To: virtio@lists.oasis-open.org, virtio-dev@lists.oasis-open.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Halil Pasic <pasic@linux.vnet.ibm.com>
Subject: [virtio] [PATCH 2/5] consistency: clean up stale wording for v1.1 terms
Date: Mon, 9 Apr 2018 20:58:39 +0200 [thread overview]
Message-ID: <1523300322-21989-3-git-send-email-pasic@linux.vnet.ibm.com> (raw)
In-Reply-To: <1523300322-21989-1-git-send-email-pasic@linux.vnet.ibm.com>
Occasionally we still use used and available ring instead of Device and
Driver Area respectively. Same goes for descriptor table with the
difference that depending on the context we need either Descriptor Area
or descriptor ring.
Let's clean these up, at least where the cleanup is trivial.
Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
---
content.tex | 14 +++++++-------
packed-ring.tex | 10 ++++++----
2 files changed, 13 insertions(+), 11 deletions(-)
diff --git a/content.tex b/content.tex
index 7a92cb1..e3ac662 100644
--- a/content.tex
+++ b/content.tex
@@ -1247,7 +1247,7 @@ The driver typically does this as follows, for each virtqueue a device has:
\item Optionally, select a smaller virtqueue size and write it to \field{queue_size}.
-\item Allocate and zero Descriptor Table, Available and Used rings for the
+\item Allocate and zero Descriptor Area, Device Area and Driver Area for the
virtqueue in contiguous physical memory.
\item Optionally, if MSI-X capability is present and enabled on the
@@ -1769,9 +1769,9 @@ nor behaviour:
writing to \field{QueueSel}.
}
\hline
- \mmioreg{QueueAlign}{Used Ring alignment in the virtual queue}{0x03c}{W}{%
+ \mmioreg{QueueAlign}{Device Area alignment in the virtual queue}{0x03c}{W}{%
Writing to this register notifies the device about alignment
- boundary of the Used Ring in bytes. This value should be a power
+ boundary of the Device Area in bytes. This value should be a power
of 2 and applies to the queue selected by writing to \field{QueueSel}.
}
\hline
@@ -1779,7 +1779,7 @@ nor behaviour:
Writing to this register notifies the device about location of the
virtual queue in the Guest's physical address space. This value
is the index number of a page starting with the queue
- Descriptor Table. Value zero (0x0) means physical address zero
+ Descriptor Area. Value zero (0x0) means physical address zero
(0x00000000) and is illegal. When the driver stops using the
queue it writes zero (0x0) to this register.
Reading from this register returns the currently used page
@@ -1830,7 +1830,7 @@ The virtual queue is configured as follows:
queue is not available.
\item Allocate and zero the queue pages in contiguous virtual
- memory, aligning the Used Ring to an optimal boundary (usually
+ memory, aligning the Device Area to an optimal boundary (usually
page size). The driver should choose a queue size smaller than or
equal to \field{QueueNumMax}.
@@ -2066,8 +2066,8 @@ struct vq_info_block {
\end{lstlisting}
\field{desc}, \field{driver} and \field{device} contain the guest
-addresses for the descriptor area,
-available area and used area for queue \field{index}, respectively. The actual
+addresses for the Descriptor Area,
+Driver Area and Device Area for queue \field{index}, respectively. The actual
virtqueue size (number of allocated buffers) is transmitted in \field{num}.
\devicenormative{\paragraph}{Configuring a Virtqueue}{Virtio Transport Options / Virtio over channel I/O / Device Initialization / Configuring a Virtqueue}
diff --git a/packed-ring.tex b/packed-ring.tex
index eb006b0..e656fed 100644
--- a/packed-ring.tex
+++ b/packed-ring.tex
@@ -445,7 +445,9 @@ struct pvirtq_event_suppress {
};
\end{lstlisting}
-\devicenormative{\subsection}{The Virtqueue Descriptor Table}{Basic Facilities of a Virtio Device / Packed Virtqueues / The Virtqueue Descriptor Table}
+\devicenormative{\subsection}{The Virtqueue Descriptor Ring}{Basic
+Facilities of a Virtio Device / Packed Virtqueues / The Virtqueue
+Descriptor Ring}
A device MUST NOT write to a device-readable buffer, and a device SHOULD NOT
read a device-writable buffer.
A device MUST NOT use a descriptor unless it observes
@@ -454,7 +456,7 @@ the VIRTQ_DESC_F_AVAIL bit in its \field{flags} being changed
A device MUST NOT change a descriptor after changing it's
the VIRTQ_DESC_F_USED bit in its \field{flags}.
-\drivernormative{\subsection}{The Virtqueue Descriptor Table}{Basic Facilities of a Virtio Device / PAcked Virtqueues / The Virtqueue Descriptor Table}
+\drivernormative{\subsection}{The Virtqueue Descriptor Ring}{Basic Facilities of a Virtio Device / PAcked Virtqueues / The Virtqueue Descriptor Ring}
A driver MUST NOT change a descriptor unless it observes
the VIRTQ_DESC_F_USED bit in its \field{flags} being changed.
A driver MUST NOT change a descriptor after changing
@@ -498,7 +500,7 @@ were made available by the driver.
The device MAY limit the number of buffers it will allow in a
list.
-\drivernormative{\subsection}{Indirect Descriptors}{Basic Facilities of a Virtio Device / Packed Virtqueues / The Virtqueue Descriptor Table / Indirect Descriptors}
+\drivernormative{\subsection}{Indirect Descriptors}{Basic Facilities of a Virtio Device / Packed Virtqueues / The Virtqueue Descriptor Ring / Indirect Descriptors}
The driver MUST NOT set the DESC_F_INDIRECT flag unless the
VIRTIO_F_INDIRECT_DESC feature was negotiated. The driver MUST NOT
set any flags except DESC_F_WRITE within an indirect descriptor.
@@ -541,7 +543,7 @@ What follows are the requirements of each stage in more detail.
For each buffer element, b:
\begin{enumerate}
-\item Get the next descriptor table entry, d
+\item Get the next descriptor ring entry, d
\item Get the next free buffer id value
\item Set \field{d.addr} to the physical address of the start of b
\item Set \field{d.len} to the length of b.
--
1.7.1
---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that
generates this mail. Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php
next prev parent reply other threads:[~2018-04-09 18:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 18:58 [virtio] [PATCH 0/5] fixes and tweaks for virtio v1.1 Halil Pasic
2018-04-09 18:58 ` [virtio] [PATCH 1/5] packed-ring: fix used descriptors but meant buffers Halil Pasic
2018-04-09 18:58 ` Halil Pasic [this message]
2018-04-10 9:30 ` [virtio] Re: [PATCH 2/5] consistency: clean up stale wording for v1.1 terms Cornelia Huck
2018-04-10 10:04 ` Halil Pasic
2018-04-10 10:06 ` Cornelia Huck
2018-04-09 18:58 ` [virtio] [PATCH 3/5] packed-packed: fix supplying buffers description Halil Pasic
2018-04-09 18:58 ` [virtio] [PATCH 4/5] packed-ring: reposition drivernormative on driver notifications Halil Pasic
2018-04-09 19:51 ` Paolo Bonzini
2018-04-10 10:25 ` Halil Pasic
2018-04-10 11:05 ` Paolo Bonzini
2018-04-10 14:59 ` Halil Pasic
2018-04-20 15:45 ` Paolo Bonzini
2018-04-20 15:59 ` Michael S. Tsirkin
2018-04-20 16:22 ` Halil Pasic
2018-04-20 16:28 ` Michael S. Tsirkin
2018-04-09 18:58 ` [virtio] [PATCH 5/5] packed-ring: tweak driver code example Halil Pasic
2018-04-20 15:00 ` [virtio] [PATCH 0/5] fixes and tweaks for virtio v1.1 Halil Pasic
2018-04-27 16:07 ` Halil Pasic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1523300322-21989-3-git-send-email-pasic@linux.vnet.ibm.com \
--to=pasic@linux.vnet.ibm.com \
--cc=cohuck@redhat.com \
--cc=mst@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtio@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox