Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: Halil Pasic <pasic@linux.vnet.ibm.com>
To: virtio@lists.oasis-open.org, virtio-dev@lists.oasis-open.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Halil Pasic <pasic@linux.vnet.ibm.com>
Subject: [virtio] [PATCH 4/5] packed-ring: reposition drivernormative on driver notifications
Date: Mon,  9 Apr 2018 20:58:41 +0200	[thread overview]
Message-ID: <1523300322-21989-5-git-send-email-pasic@linux.vnet.ibm.com> (raw)
In-Reply-To: <1523300322-21989-1-git-send-email-pasic@linux.vnet.ibm.com>

The drivernormative was simply in the wrong place. It does not belong
to the code example.

Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
---
 packed-ring.tex |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/packed-ring.tex b/packed-ring.tex
index d93df3b..388850b 100644
--- a/packed-ring.tex
+++ b/packed-ring.tex
@@ -600,6 +600,10 @@ Suppression Structure Format}.
 The driver has to be careful to expose the new \field{flags}
 value before checking if notifications are suppressed.
 
+\drivernormative{\paragraph}{Notifying The Device}{Basic Facilities of a Virtio Device / Packed Virtqueues / Supplying Buffers to The Device / Notifying The Device}
+The driver MUST perform a suitable memory barrier before reading
+the Driver Event Suppression structure, to avoid missing a notification.
+
 \subsubsection{Implementation Example}\label{sec:Basic Facilities of a Virtio Device / Packed Virtqueues / Supplying Buffers to The Device / Implementation Example}
 
 Below is a driver code example. It does not attempt to reduce
@@ -658,11 +662,6 @@ if (vq->device_event.flags != RING_EVENT_FLAGS_DISABLE) {
 
 \end{lstlisting}
 
-
-\drivernormative{\paragraph}{Notifying The Device}{Basic Facilities of a Virtio Device / Packed Virtqueues / Supplying Buffers to The Device / Notifying The Device}
-The driver MUST perform a suitable memory barrier before reading
-the Driver Event Suppression structure, to avoid missing a notification.
-
 \subsection{Receiving Used Buffers From The Device}\label{sec:Basic Facilities of a Virtio Device / Packed Virtqueues / Receiving Used Buffers From The Device}
 
 Once the device has used buffers referred to by a descriptor (read from or written to them, or
-- 
1.7.1


---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that 
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php 


  parent reply	other threads:[~2018-04-09 18:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-09 18:58 [virtio] [PATCH 0/5] fixes and tweaks for virtio v1.1 Halil Pasic
2018-04-09 18:58 ` [virtio] [PATCH 1/5] packed-ring: fix used descriptors but meant buffers Halil Pasic
2018-04-09 18:58 ` [virtio] [PATCH 2/5] consistency: clean up stale wording for v1.1 terms Halil Pasic
2018-04-10  9:30   ` [virtio] " Cornelia Huck
2018-04-10 10:04     ` Halil Pasic
2018-04-10 10:06       ` Cornelia Huck
2018-04-09 18:58 ` [virtio] [PATCH 3/5] packed-packed: fix supplying buffers description Halil Pasic
2018-04-09 18:58 ` Halil Pasic [this message]
2018-04-09 19:51   ` [virtio] [PATCH 4/5] packed-ring: reposition drivernormative on driver notifications Paolo Bonzini
2018-04-10 10:25     ` Halil Pasic
2018-04-10 11:05       ` Paolo Bonzini
2018-04-10 14:59         ` Halil Pasic
2018-04-20 15:45           ` Paolo Bonzini
2018-04-20 15:59           ` Michael S. Tsirkin
2018-04-20 16:22             ` Halil Pasic
2018-04-20 16:28               ` Michael S. Tsirkin
2018-04-09 18:58 ` [virtio] [PATCH 5/5] packed-ring: tweak driver code example Halil Pasic
2018-04-20 15:00 ` [virtio] [PATCH 0/5] fixes and tweaks for virtio v1.1 Halil Pasic
2018-04-27 16:07   ` Halil Pasic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1523300322-21989-5-git-send-email-pasic@linux.vnet.ibm.com \
    --to=pasic@linux.vnet.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=mst@redhat.com \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtio@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox