From: Cornelia Huck <cohuck@redhat.com>
To: Halil Pasic <pasic@linux.vnet.ibm.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
virtio@lists.oasis-open.org, virtio-dev@lists.oasis-open.org,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [virtio] [RFC PATCH 1/3] notifications: unify notifications wording in core
Date: Wed, 11 Apr 2018 13:47:11 +0200 [thread overview]
Message-ID: <20180411134711.3f70b875.cohuck@redhat.com> (raw)
In-Reply-To: <360d1dd8-f8a3-a7bc-c75f-fcae7a3fb729@linux.vnet.ibm.com>
On Wed, 11 Apr 2018 12:58:37 +0200
Halil Pasic <pasic@linux.vnet.ibm.com> wrote:
> On 04/11/2018 04:19 AM, Stefan Hajnoczi wrote:
> > On Wed, Apr 11, 2018 at 12:11:25AM +0200, Halil Pasic wrote:
> >> \begin{lstlisting}
> >> -virtq_disable_interrupts(vq);
> >> +virtq_disable_notifications(vq);
> >
> > This name is ambiguous. Only used buffer notifications are disabled,
> > not configuration change notifications.
> >
>
> One could argue that the only virtqueue scoped notification received
> by the driver are used buffer notifications. That's why I thought
> this would be sufficient (btw. if it's ambiguous it was ambiguous before
> too as both options are called interrupts).
>
> But the more straight-forward the better.
Agreed.
>
> > How about:
> >
> > virtq_disable_used_buffer_notifications(vq);
> >
>
> In absence of further discussion I will take this for the next
> version.
Sounds good to me.
---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that
generates this mail. Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php
next prev parent reply other threads:[~2018-04-11 11:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 22:11 [virtio] [RFC PATCH 0/3] rework notifications terminology Halil Pasic
2018-04-10 22:11 ` [virtio] [RFC PATCH 1/3] notifications: unify notifications wording in core Halil Pasic
2018-04-11 2:19 ` Stefan Hajnoczi
2018-04-11 10:58 ` Halil Pasic
2018-04-11 11:47 ` Cornelia Huck [this message]
2018-04-11 12:35 ` [virtio] Re: [virtio-dev] " Paolo Bonzini
2018-04-11 12:55 ` Cornelia Huck
2018-04-11 13:11 ` Paolo Bonzini
2018-04-10 22:11 ` [virtio] [RFC PATCH 2/3] notifications:notifications as basic virtio facility Halil Pasic
2018-04-11 13:11 ` [virtio] " Cornelia Huck
2018-04-10 22:11 ` [virtio] [RFC PATCH 3/3] ccw: map common notifications terminology to ccw Halil Pasic
2018-04-11 7:50 ` [virtio] " Cornelia Huck
2018-04-11 13:42 ` [virtio] Re: [virtio-dev] " Halil Pasic
2018-04-11 16:00 ` Cornelia Huck
2018-04-12 11:12 ` Halil Pasic
2018-04-13 9:47 ` Cornelia Huck
2018-04-20 14:53 ` [virtio] Re: [RFC PATCH 0/3] rework notifications terminology Halil Pasic
2018-04-20 15:44 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180411134711.3f70b875.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=mst@redhat.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=stefanha@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtio@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox