Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: cohuck@redhat.com, stefanha@redhat.com, pbonzini@redhat.com,
	virtio-dev@lists.oasis-open.org, dan.daly@intel.com,
	cunming.liang@intel.com, zhihong.wang@intel.com
Subject: [virtio-dev] Re: [PATCH v3] content: enhance device requirements for feature bits
Date: Mon, 11 Jun 2018 16:24:51 +0300	[thread overview]
Message-ID: <20180611162354-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180611075640.19751-1-tiwei.bie@intel.com>

On Mon, Jun 11, 2018 at 03:56:40PM +0800, Tiwei Bie wrote:
> Suggested-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/14
> ---
> v2:
> - Refine the wording (Cornelia);
> 
> v3:
> - Refine the wording (MST);
> 
>  content.tex | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/content.tex b/content.tex
> index f996fad..3c7d67d 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -125,6 +125,13 @@ which was not offered.  The device SHOULD accept any valid subset
>  of features the driver accepts, otherwise it MUST fail to set the
>  FEATURES_OK \field{device status} bit when the driver writes it.
>  
> +If a device has successfully negotiated a set of features
> +at least once (by accepting the FEATURES_OK \field{device
> +status} bit during device initialization), then it SHOULD
> +NOT fail re-negotiation of the same set of features after
> +a device or system reset.  Failure to do so would interfere
> +with resuming from suspend and error recovery.
> +
>  \subsection{Legacy Interface: A Note on Feature
>  Bits}\label{sec:Basic Facilities of a Virtio Device / Feature
>  Bits / Legacy Interface: A Note on Feature Bits}

OK but there's no \field{device status} anywhere
else I think.
We only have \field{status} in spec.


> -- 
> 2.17.0

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  parent reply	other threads:[~2018-06-11 13:25 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-11  7:56 [virtio-dev] [PATCH v3] content: enhance device requirements for feature bits Tiwei Bie
2018-06-11  8:43 ` [virtio-dev] " Cornelia Huck
2018-06-11 13:24 ` Michael S. Tsirkin [this message]
2018-06-11 13:29   ` Cornelia Huck
2018-06-11 13:44     ` Michael S. Tsirkin
2018-06-11 13:44 ` Michael S. Tsirkin
2018-06-15 12:10 ` [virtio-dev] " Halil Pasic
2018-06-15 12:19   ` Michael S. Tsirkin
2018-06-15 12:42     ` Halil Pasic
2018-06-15 13:38       ` Michael S. Tsirkin
2018-06-15 15:16         ` Halil Pasic
2018-06-15 15:37           ` Michael S. Tsirkin
2018-06-18 15:08             ` Halil Pasic
2018-06-18 16:28               ` Michael S. Tsirkin
2018-06-19  9:14                 ` Tiwei Bie
2018-06-19 10:46                   ` Halil Pasic
2018-06-19 16:30                     ` Tiwei Bie
2018-06-20  7:54                       ` Cornelia Huck
2018-06-20 12:10                       ` Halil Pasic
2018-06-20  1:06                   ` Michael S. Tsirkin
2018-06-15 13:39       ` Tiwei Bie
2018-06-15 14:21         ` Halil Pasic
2018-06-15 15:36           ` Michael S. Tsirkin
2018-06-15 18:06             ` Halil Pasic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180611162354-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=cunming.liang@intel.com \
    --cc=dan.daly@intel.com \
    --cc=pbonzini@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=tiwei.bie@intel.com \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox