[virtio-dev] [PATCH 0/2] Typos, grammar and cosmetic fixes

[virtio-dev] [PATCH 0/2] Typos, grammar and cosmetic fixes

[Daniel Marcovitch]

The following couple of patches fix some typos, grammar and other cosmetic issues

Daniel Marcovitch (2):
  packed-ring/split-ring/content: fixed misc typos
  queue_size: renamed "hypervisor" to "device"

 content.tex     | 4 ++--
 packed-ring.tex | 2 +-
 split-ring.tex  | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

-- 
1.8.3.1


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

[virtio-dev] [PATCH 1/2] packed-ring/split-ring/content: fixed misc typos

[Daniel Marcovitch]

---
 content.tex     | 2 +-
 packed-ring.tex | 2 +-
 split-ring.tex  | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/content.tex b/content.tex
index c346183..fb168a0 100644
--- a/content.tex
+++ b/content.tex
@@ -346,7 +346,7 @@ The driver MUST follow this sequence to initialize a device:
 \begin{enumerate}
 \item Reset the device.
 
-\item Set the ACKNOWLEDGE status bit: the guest OS has notice the device.
+\item Set the ACKNOWLEDGE status bit: the guest OS has noticed the device.
 
 \item Set the DRIVER status bit: the guest OS knows how to drive the device.
 
diff --git a/packed-ring.tex b/packed-ring.tex
index ebbad95..f24f49b 100644
--- a/packed-ring.tex
+++ b/packed-ring.tex
@@ -186,7 +186,7 @@ described completely by a single descriptor.
 While unusual (most implementations either create all lists
 solely using non-indirect descriptors, or always use a single
 indirect element), if both features have been negotiated, mixing
-direct and direct descriptors in a ring is valid, as long as each
+indirect and non-indirect descriptors in a ring is valid, as long as each
 list only contains descriptors of a given type.
 
 Scatter/gather lists only apply to available descriptors. A
diff --git a/split-ring.tex b/split-ring.tex
index be0cd2f..7b75b1a 100644
--- a/split-ring.tex
+++ b/split-ring.tex
@@ -220,7 +220,7 @@ read a device-writable buffer (it MAY do so for debugging or diagnostic
 purposes).
 
 \drivernormative{\subsubsection}{The Virtqueue Descriptor Table}{Basic Facilities of a Virtio Device / Virtqueues / The Virtqueue Descriptor Table}
-Drivers MUST NOT add a descriptor chain over than $2^{32}$ bytes long in total;
+Drivers MUST NOT add a descriptor chain over $2^{32}$ bytes long in total;
 this implies that loops in the descriptor chain are forbidden!
 
 If VIRTIO_F_IN_ORDER has been negotiated, and when making a
@@ -560,7 +560,7 @@ The driver offers buffers to one of the device's virtqueues as follows:
 \item Steps \ref{itm:Basic Facilities of a Virtio Device / Virtqueues / Supplying Buffers to The Device / Place Buffers} and \ref{itm:Basic Facilities of a Virtio Device / Virtqueues / Supplying Buffers to The Device / Place Index} MAY be performed repeatedly if batching
   is possible.
 
-\item The driver performs suitable a memory barrier to ensure the device sees
+\item The driver performs a suitable memory barrier to ensure the device sees
   the updated descriptor table and available ring before the next
   step.
 
-- 
1.8.3.1


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

Re: [virtio-dev] [PATCH 1/2] packed-ring/split-ring/content: fixed misc typos

[Cornelia Huck]

On Tue, 30 Oct 2018 11:28:31 +0200
Daniel Marcovitch <danielm@mellanox.com> wrote:

> ---
>  content.tex     | 2 +-
>  packed-ring.tex | 2 +-
>  split-ring.tex  | 4 ++--
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 

Reviewed-by: Cornelia Huck <cohuck@redhat.com>

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

Re: [virtio-dev] [PATCH 1/2] packed-ring/split-ring/content: fixed misc typos

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 528 bytes --]

On Tue, Oct 30, 2018 at 11:28:31AM +0200, Daniel Marcovitch wrote:
>  \drivernormative{\subsubsection}{The Virtqueue Descriptor Table}{Basic Facilities of a Virtio Device / Virtqueues / The Virtqueue Descriptor Table}
> -Drivers MUST NOT add a descriptor chain over than $2^{32}$ bytes long in total;
> +Drivers MUST NOT add a descriptor chain over $2^{32}$ bytes long in total;
>  this implies that loops in the descriptor chain are forbidden!

s/long//

Or, even better:

descriptor chain longer than $2^{32}$ bytes in total;

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

[virtio-dev] [PATCH 2/2] queue_size: renamed "hypervisor" to "device"

[Daniel Marcovitch]

fixed to be consistent with the device/driver terminology in other surrounding descriptions
---
 content.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/content.tex b/content.tex
index fb168a0..3ae3eb2 100644
--- a/content.tex
+++ b/content.tex
@@ -794,7 +794,7 @@ struct virtio_pci_common_cfg {
 
 \item[\field{queue_size}]
         Queue Size.  On reset, specifies the maximum queue size supported by
-        the hypervisor. This can be modified by driver to reduce memory requirements.
+        the device. This can be modified by driver to reduce memory requirements.
         A 0 means the queue is unavailable.
 
 \item[\field{queue_msix_vector}]
-- 
1.8.3.1


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

Re: [virtio-dev] [PATCH 2/2] queue_size: renamed "hypervisor" to "device"

[Cornelia Huck]

On Tue, 30 Oct 2018 11:28:32 +0200
Daniel Marcovitch <danielm@mellanox.com> wrote:

> fixed to be consistent with the device/driver terminology in other surrounding descriptions
> ---
>  content.tex | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/content.tex b/content.tex
> index fb168a0..3ae3eb2 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -794,7 +794,7 @@ struct virtio_pci_common_cfg {
>  
>  \item[\field{queue_size}]
>          Queue Size.  On reset, specifies the maximum queue size supported by
> -        the hypervisor. This can be modified by driver to reduce memory requirements.
> +        the device. This can be modified by driver to reduce memory requirements.

Makes sense. But perhaps s/driver/the driver/ as well?

>          A 0 means the queue is unavailable.
>  
>  \item[\field{queue_msix_vector}]


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

Re: [virtio-dev] [PATCH 2/2] queue_size: renamed "hypervisor" to "device"

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 290 bytes --]

On Tue, Oct 30, 2018 at 11:28:32AM +0200, Daniel Marcovitch wrote:
> fixed to be consistent with the device/driver terminology in other surrounding descriptions
> ---
>  content.tex | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]