Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Pankaj Gupta <pagupta@redhat.com>
Cc: virtio-dev@lists.oasis-open.org, stefanha@redhat.com, cohuck@redhat.com
Subject: [virtio-dev] Re: [PATCH v2] content: reserve device ID for virtio-pmem devices
Date: Fri, 19 Apr 2019 19:23:14 -0400	[thread overview]
Message-ID: <20190419192118-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20190415062239.19717-1-pagupta@redhat.com>

On Mon, Apr 15, 2019 at 11:52:39AM +0530, Pankaj Gupta wrote:
> We need a device ID for virtio-pmem devices. As 25 is requested by
> audio device and 26 is requested by virtio-fs, so requesting
> next available(27). Also, updated the previously requested github
> issue[1] for voting.
> 
> [1] https://github.com/oasis-tcs/virtio-spec/issues/38

That's not the way to link it. You want:
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/38

Otherwise github will not recognize it.
Also for guthub pls edit the main issue with new link to patch do not add new patch as
a comment.


> 
> Signed-off-by: Pankaj Gupta <pagupta@redhat.com>


> ---
> v2:
>  Use device ID 27
>  
>  content.tex | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/content.tex b/content.tex
> index 193b6e1..aef7476 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -2634,6 +2634,8 @@ \chapter{Device Types}\label{sec:Device Types}
>  \hline
>  24         &   Memory device \\
>  \hline
> +27         &   PMEM device \\
> +\hline
>  \end{tabular}
>  
>  Some of the devices above are unspecified by this document,
> -- 
> 2.14.5

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  parent reply	other threads:[~2019-04-19 23:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-15  6:22 [virtio-dev] [PATCH v2] content: reserve device ID for virtio-pmem devices Pankaj Gupta
2019-04-15  8:00 ` [virtio-dev] " Cornelia Huck
2019-04-15  8:29   ` Pankaj Gupta
2019-04-19 23:23 ` Michael S. Tsirkin [this message]
2019-04-22  5:25   ` Pankaj Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190419192118-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=pagupta@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox