[virtio-dev] Re: [PATCH v2] content: reserve device ID for virtio-pmem devices

[Pankaj Gupta <pagupta@redhat.com>]

> On Mon, Apr 15, 2019 at 11:52:39AM +0530, Pankaj Gupta wrote:
> > We need a device ID for virtio-pmem devices. As 25 is requested by
> > audio device and 26 is requested by virtio-fs, so requesting
> > next available(27). Also, updated the previously requested github
> > issue[1] for voting.
> > 
> > [1] https://github.com/oasis-tcs/virtio-spec/issues/38
> 
> That's not the way to link it. You want:
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/38
> 
> Otherwise github will not recognize it.
> Also for guthub pls edit the main issue with new link to patch do not add new
> patch as
> a comment.

Sure. Submitted a new version v3 with suggested change.
Also, updated the github main issue with link to patch.

Thanks,
Pankaj
> 
> 
> > 
> > Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
> 
> 
> > ---
> > v2:
> >  Use device ID 27
> >  
> >  content.tex | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/content.tex b/content.tex
> > index 193b6e1..aef7476 100644
> > --- a/content.tex
> > +++ b/content.tex
> > @@ -2634,6 +2634,8 @@ \chapter{Device Types}\label{sec:Device Types}
> >  \hline
> >  24         &   Memory device \\
> >  \hline
> > +27         &   PMEM device \\
> > +\hline
> >  \end{tabular}
> >  
> >  Some of the devices above are unspecified by this document,
> > --
> > 2.14.5
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org