Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: Alexander Duyck <alexander.duyck@gmail.com>
To: virtio-dev@lists.oasis-open.org, kvm@vger.kernel.org,
	mst@redhat.com, catalin.marinas@arm.com, david@redhat.com,
	dave.hansen@intel.com, linux-kernel@vger.kernel.org,
	willy@infradead.org, mhocko@kernel.org, linux-mm@kvack.org,
	akpm@linux-foundation.org, will@kernel.org,
	linux-arm-kernel@lists.infradead.org, osalvador@suse.de
Cc: yang.zhang.wz@gmail.com, pagupta@redhat.com,
	konrad.wilk@oracle.com, nitesh@redhat.com, riel@surriel.com,
	lcapitulino@redhat.com, wei.w.wang@intel.com,
	aarcange@redhat.com, ying.huang@intel.com, pbonzini@redhat.com,
	dan.j.williams@intel.com, fengguang.wu@intel.com,
	alexander.h.duyck@linux.intel.com,
	kirill.shutemov@linux.intel.com
Subject: [virtio-dev] [PATCH v9 3/8] mm: Move set/get_pcppage_migratetype to mmzone.h
Date: Sat, 07 Sep 2019 10:25:28 -0700	[thread overview]
Message-ID: <20190907172528.10910.37051.stgit@localhost.localdomain> (raw)
In-Reply-To: <20190907172225.10910.34302.stgit@localhost.localdomain>

From: Alexander Duyck <alexander.h.duyck@linux.intel.com>

In order to support page reporting it will be necessary to store and
retrieve the migratetype of a page. To enable that I am moving the set and
get operations for pcppage_migratetype into the mm/internal.h header so
that they can be used outside of the page_alloc.c file.

Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
---
 mm/internal.h   |   18 ++++++++++++++++++
 mm/page_alloc.c |   18 ------------------
 2 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/mm/internal.h b/mm/internal.h
index 0d5f720c75ab..e4a1a57bbd40 100644
--- a/mm/internal.h
+++ b/mm/internal.h
@@ -549,6 +549,24 @@ static inline bool is_migrate_highatomic_page(struct page *page)
 	return get_pageblock_migratetype(page) == MIGRATE_HIGHATOMIC;
 }
 
+/*
+ * A cached value of the page's pageblock's migratetype, used when the page is
+ * put on a pcplist. Used to avoid the pageblock migratetype lookup when
+ * freeing from pcplists in most cases, at the cost of possibly becoming stale.
+ * Also the migratetype set in the page does not necessarily match the pcplist
+ * index, e.g. page might have MIGRATE_CMA set but be on a pcplist with any
+ * other index - this ensures that it will be put on the correct CMA freelist.
+ */
+static inline int get_pcppage_migratetype(struct page *page)
+{
+	return page->index;
+}
+
+static inline void set_pcppage_migratetype(struct page *page, int migratetype)
+{
+	page->index = migratetype;
+}
+
 void setup_zone_pageset(struct zone *zone);
 extern struct page *alloc_new_node_page(struct page *page, unsigned long node);
 #endif	/* __MM_INTERNAL_H */
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 4e4356ba66c7..a791f2baeeeb 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -185,24 +185,6 @@ static int __init early_init_on_free(char *buf)
 }
 early_param("init_on_free", early_init_on_free);
 
-/*
- * A cached value of the page's pageblock's migratetype, used when the page is
- * put on a pcplist. Used to avoid the pageblock migratetype lookup when
- * freeing from pcplists in most cases, at the cost of possibly becoming stale.
- * Also the migratetype set in the page does not necessarily match the pcplist
- * index, e.g. page might have MIGRATE_CMA set but be on a pcplist with any
- * other index - this ensures that it will be put on the correct CMA freelist.
- */
-static inline int get_pcppage_migratetype(struct page *page)
-{
-	return page->index;
-}
-
-static inline void set_pcppage_migratetype(struct page *page, int migratetype)
-{
-	page->index = migratetype;
-}
-
 #ifdef CONFIG_PM_SLEEP
 /*
  * The following functions are used by the suspend/hibernate code to temporarily


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  parent reply	other threads:[~2019-09-07 17:25 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-07 17:25 [virtio-dev] [PATCH v9 0/8] stg mail -e --version=v9 \ Alexander Duyck
2019-09-07 17:25 ` [virtio-dev] [PATCH v9 1/8] mm: Add per-cpu logic to page shuffling Alexander Duyck
2019-09-09  8:14   ` [virtio-dev] " David Hildenbrand
2019-09-09 15:11     ` Alexander Duyck
     [not found]       ` <20190910121130.GU2063@dhcp22.suse.cz>
2019-09-10 22:14         ` Alexander Duyck
2019-09-10 22:11     ` Alexander Duyck
     [not found]   ` <20190909090701.7ebz4foxyu3rxzvc@box>
2019-09-09 15:12     ` Alexander Duyck
2019-09-07 17:25 ` [virtio-dev] [PATCH v9 2/8] mm: Adjust shuffle code to allow for future coalescing Alexander Duyck
2019-09-09  8:19   ` [virtio-dev] " David Hildenbrand
     [not found]   ` <20190909094700.bbslsxpuwvxmodal@box>
2019-09-09 15:22     ` Alexander Duyck
     [not found]       ` <20190909153529.3crs74uraos27ffh@box>
2019-09-09 15:37         ` Alexander Duyck
2019-09-09 16:43     ` Alexander Duyck
     [not found]   ` <20190910122030.GV2063@dhcp22.suse.cz>
2019-09-10 14:48     ` Alexander Duyck
2019-09-07 17:25 ` Alexander Duyck [this message]
2019-09-09  8:22   ` [virtio-dev] Re: [PATCH v9 3/8] mm: Move set/get_pcppage_migratetype to mmzone.h David Hildenbrand
     [not found]   ` <20190909095608.jwachx3womhqmjbl@box>
2019-09-09 18:01     ` Alexander Duyck
2019-09-09 18:12       ` Alexander Duyck
     [not found]   ` <20190910122313.GW2063@dhcp22.suse.cz>
2019-09-10 14:46     ` Alexander Duyck
     [not found]       ` <20190910174553.GC4023@dhcp22.suse.cz>
2019-09-10 20:26         ` Alexander Duyck
2019-09-07 17:25 ` [virtio-dev] [PATCH v9 4/8] mm: Use zone and order instead of free area in free_list manipulators Alexander Duyck
2019-09-07 17:25 ` [virtio-dev] [PATCH v9 5/8] arm64: Move hugetlb related definitions out of pgtable.h to page-defs.h Alexander Duyck
2019-09-09  8:52   ` [virtio-dev] " David Hildenbrand
2019-09-09 15:27     ` Alexander Duyck
     [not found]   ` <20190917174853.5csycb5pb5zalsxd@willie-the-truck>
2019-09-17 20:07     ` Alexander Duyck
2019-09-07 17:25 ` [virtio-dev] [PATCH v9 6/8] mm: Introduce Reported pages Alexander Duyck
     [not found]   ` <20190909144209.jcrx6o3ntecdaqmh@box>
2019-09-09 16:25     ` [virtio-dev] " Alexander Duyck
2019-09-07 17:26 ` [virtio-dev] [PATCH v9 7/8] virtio-balloon: Pull page poisoning config out of free page hinting Alexander Duyck
2019-09-09  8:59   ` [virtio-dev] " David Hildenbrand
2019-09-09 15:31     ` Alexander Duyck
2019-09-07 17:26 ` [virtio-dev] [PATCH v9 8/8] virtio-balloon: Add support for providing unused page reports to host Alexander Duyck
2019-09-07 17:34 ` [virtio-dev] Re: [PATCH v9 0/8] mm / virtio: Provide support for unused page reporting Alexander Duyck
     [not found] ` <20190910124209.GY2063@dhcp22.suse.cz>
2019-09-10 14:42   ` [virtio-dev] Re: [PATCH v9 0/8] stg mail -e --version=v9 \ Alexander Duyck
     [not found]     ` <20190910144713.GF2063@dhcp22.suse.cz>
2019-09-10 16:05       ` Alexander Duyck
2019-09-10 16:18         ` Dr. David Alan Gilbert
2019-09-10 16:22           ` David Hildenbrand
2019-09-11  9:23             ` Michael S. Tsirkin
2019-09-11  9:50               ` David Hildenbrand
     [not found]         ` <20190910175213.GD4023@dhcp22.suse.cz>
     [not found]           ` <20190910180026.GE4023@dhcp22.suse.cz>
2019-09-10 20:37             ` Alexander Duyck
2019-09-10 21:23           ` Alexander Duyck
     [not found]             ` <20190911113619.GP4023@dhcp22.suse.cz>
2019-09-11 11:47               ` David Hildenbrand
2019-09-11 12:08               ` Michael S. Tsirkin
     [not found]                 ` <20190911121941.GU4023@dhcp22.suse.cz>
     [not found]                   ` <20190911122526.GV4023@dhcp22.suse.cz>
2019-09-11 12:42                     ` David Hildenbrand
2019-09-11 12:55                       ` Nitesh Narayan Lal
     [not found]                       ` <20190911125413.GY4023@dhcp22.suse.cz>
2019-09-11 13:03                         ` David Hildenbrand
     [not found]                           ` <20190911132002.GA4023@dhcp22.suse.cz>
2019-09-11 14:03                             ` Nitesh Narayan Lal
2019-09-11 16:02                             ` David Hildenbrand
     [not found]                             ` <20190911135100.GC4023@dhcp22.suse.cz>
2019-09-11 16:09                               ` David Hildenbrand
     [not found]                                 ` <20190912071633.GL4023@dhcp22.suse.cz>
2019-09-12  7:47                                   ` David Hildenbrand
2019-09-12 12:00                                     ` Nitesh Narayan Lal
2019-09-11 13:19                         ` Nitesh Narayan Lal
2019-09-11 15:12               ` Alexander Duyck
     [not found]                 ` <20190912091925.GM4023@dhcp22.suse.cz>
2019-09-12 15:42                   ` Alexander Duyck
     [not found]                   ` <20190912163525.GV2739@techsingularity.net>
2019-09-12 17:48                     ` Alexander Duyck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190907172528.10910.37051.stgit@localhost.localdomain \
    --to=alexander.duyck@gmail.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.h.duyck@linux.intel.com \
    --cc=catalin.marinas@arm.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=david@redhat.com \
    --cc=fengguang.wu@intel.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=konrad.wilk@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=lcapitulino@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=mst@redhat.com \
    --cc=nitesh@redhat.com \
    --cc=osalvador@suse.de \
    --cc=pagupta@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=riel@surriel.com \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=wei.w.wang@intel.com \
    --cc=will@kernel.org \
    --cc=willy@infradead.org \
    --cc=yang.zhang.wz@gmail.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox