Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: "virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>,
	"virtio-comment@lists.oasis-open.org"
	<virtio-comment@lists.oasis-open.org>
Subject: [virtio-comment] Re: [PATCH v1 00/20] Split device spec to its individual files
Date: Tue, 3 Jan 2023 10:43:30 -0500	[thread overview]
Message-ID: <20230103104223-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <PH0PR12MB5481D2990D83282101967A8CDCF49@PH0PR12MB5481.namprd12.prod.outlook.com>

On Tue, Jan 03, 2023 at 02:26:15PM +0000, Parav Pandit wrote:
> 
> > From: Michael S. Tsirkin <mst@redhat.com>
> > Sent: Tuesday, January 3, 2023 9:20 AM
> > 
> > On Tue, Jan 03, 2023 at 02:15:37PM +0000, Parav Pandit wrote:
> > >
> > > > From: Michael S. Tsirkin <mst@redhat.com>
> > > > Sent: Tuesday, January 3, 2023 5:47 AM
> > > >
> > > > On Sun, Jan 01, 2023 at 08:08:04PM +0200, Parav Pandit wrote:
> > > > > Relatively several of the recent device specifications are
> > > > > maintained in their own specification file. Such separate files
> > > > > enables better maintenance of the specification overall.
> > > > > However, several of the initial virtio device specifications are
> > > > > located in single file.
> > > > >
> > > > > Hence, split them into their individual files.
> > > > >
> > > > > Additionally, each device's driver and device conformance is
> > > > > present in one giant conformance file all together.
> > > > >
> > > > > As Michael suggest's move this device and driver conformance
> > > > > section adjacent to device specification in each device specific directory.
> > > > > This further makes device specification self-contained.
> > > > >
> > > > > Added patch to fix spelling errors in network device specification
> > > > > which was inherited from its previous file location.
> > > > >
> > > > > Patches do not change any part of the specification outcome except
> > > > > fixing the spelling errors.
> > > > > It only changes how the specification is maintained.
> > > >
> > > >
> > > > OK it's a technicality but it's a big change so I think we should
> > > > vote on this. Still I don't feel it needs extra time for review.
> > > > Can you create a github issue and I'll kick off the voting process?
> > > >
> > > Great.
> > > I already open last week [1].
> > > [1] https://github.com/oasis-tcs/virtio-spec/issues/153
> > 
> > Sounds good. What do you think about the idea to have all files flat in the same
> > directory?
> 
> I was writing up reply to other thread at the moment.
> But lets continue here since you ask.
> I don't have a strong opinion, but I find directories neat.
> This is because we have many devices spec files, conformance files and it's expected to grow.
> I have transports directory and place code in there.
> Since latex spec doesn't have good way to include and refer sub section, we have many files.
> 19 devices * 3 spec files + 3 transports * 3 spec files.
> 
> And once spec is in its own directory, things should be self-sufficient.
> Only touch points will be in common areas which should be less frequent.
> WDYT?

Yea I know. It's just that one of the ways we publish is a directory in
a web browser and there browsing up and down is annoying.
But if you feel strongly we can make the TC decide.

-- 
MST


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


  reply	other threads:[~2023-01-03 15:43 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-01 18:08 [virtio-comment] [PATCH v1 00/20] Split device spec to its individual files Parav Pandit
2023-01-01 18:08 ` [virtio-dev] [PATCH v1 01/20] virtio-network: Maintain network device spec in separate directory Parav Pandit
2023-01-09 13:42   ` [virtio-comment] " Michael S. Tsirkin
2023-01-09 14:12     ` [virtio-comment] " Parav Pandit
2023-01-09 17:16       ` [virtio-dev] " Michael S. Tsirkin
2023-01-09 19:14       ` [virtio-comment] " Michael S. Tsirkin
2023-01-09 22:41         ` [virtio-comment] " Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 02/20] virtio-network: Fix spelling errors Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 03/20] virtio-block: Maintain block device spec in separate directory Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 04/20] virtio-console: Maintain console " Parav Pandit
2023-01-01 18:08 ` [virtio-dev] [PATCH v1 05/20] virtio-entropy: Maintain entropy " Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 06/20] virtio-mem-balloon: Maintain mem balloon " Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 07/20] virtio-scsi: Maintain scsi host " Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 08/20] virtio-gpu: Maintain gpu " Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 09/20] virtio-input: Maintain input " Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 10/20] virtio-crypto: Maintain crypto " Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 11/20] virtio-vsock: Maintain socket " Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 12/20] virtio-fs: Maintain file system " Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 13/20] virtio-rpmb: Maintain rpmb " Parav Pandit
2023-01-09 12:48   ` Cornelia Huck
2023-01-09 13:35     ` Michael S. Tsirkin
2023-01-09 13:47       ` [virtio-dev] " Cornelia Huck
2023-01-09 13:53         ` Cornelia Huck
2023-01-09 14:13         ` Parav Pandit
2023-01-09 14:08       ` Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 14/20] virtio-iommu: Maintain iommu " Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 15/20] virtio-sound: Maintain sound " Parav Pandit
2023-01-09 13:05   ` [virtio-dev] " Cornelia Huck
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 16/20] virtio-mem: Maintain memory " Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 17/20] virtio-i2c: Maintain i2c " Parav Pandit
2023-01-09 13:07   ` [virtio-dev] " Cornelia Huck
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 18/20] virtio-scmi: Maintain scmi " Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 19/20] virtio-gpio: Maintain gpio " Parav Pandit
2023-01-09 13:11   ` Cornelia Huck
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 20/20] virtio-pmem: Maintain pmem " Parav Pandit
2023-01-03 10:47 ` [virtio-dev] Re: [PATCH v1 00/20] Split device spec to its individual files Michael S. Tsirkin
2023-01-03 14:15   ` [virtio-comment] " Parav Pandit
2023-01-03 14:19     ` [virtio-comment] " Michael S. Tsirkin
2023-01-03 14:26       ` [virtio-dev] " Parav Pandit
2023-01-03 15:43         ` Michael S. Tsirkin [this message]
2023-01-03 16:04           ` [virtio-comment] " Parav Pandit
2023-01-03 16:19             ` [virtio-comment] " Michael S. Tsirkin
2023-01-03 16:41               ` [virtio-comment] " Parav Pandit
2023-01-03 16:52                 ` [virtio-dev] " Michael S. Tsirkin
2023-01-03 18:00                   ` [virtio-comment] " Parav Pandit
2023-01-03 11:01 ` [virtio-comment] " Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230103104223-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=parav@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox