From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: "virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>
Subject: [virtio-dev] Re: [PATCH v1 01/20] virtio-network: Maintain network device spec in separate directory
Date: Mon, 9 Jan 2023 12:16:33 -0500 [thread overview]
Message-ID: <20230109121558-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <PH0PR12MB54814FCB63E60BE7F5985A15DCFE9@PH0PR12MB5481.namprd12.prod.outlook.com>
On Mon, Jan 09, 2023 at 02:12:36PM +0000, Parav Pandit wrote:
>
> > From: Michael S. Tsirkin <mst@redhat.com>
> > Sent: Monday, January 9, 2023 8:43 AM
> >
> > I found another issue with this. Currently for redline diff generation
> > we use latexpand. Using a flat expanded file has lots of benefits, in
> > particular latexdiff is sometimes fragile as it is, with a flat file
> > one can at least see the input it gets.
> >
> > We should either stick with \\input or more work is needed on
> > these scripts. Besides, we are already using \\input and I like
> > consistency.
> >
> > So my preference is \\input for now.
> \\input doesn't support reading from the directory.
In that case let's put everything in the same directory.
The argument for splitting things was weak anyway.
--
MST
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-01-09 17:16 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-01 18:08 [virtio-comment] [PATCH v1 00/20] Split device spec to its individual files Parav Pandit
2023-01-01 18:08 ` [virtio-dev] [PATCH v1 01/20] virtio-network: Maintain network device spec in separate directory Parav Pandit
2023-01-09 13:42 ` [virtio-comment] " Michael S. Tsirkin
2023-01-09 14:12 ` [virtio-comment] " Parav Pandit
2023-01-09 17:16 ` Michael S. Tsirkin [this message]
2023-01-09 19:14 ` [virtio-comment] " Michael S. Tsirkin
2023-01-09 22:41 ` [virtio-comment] " Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 02/20] virtio-network: Fix spelling errors Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 03/20] virtio-block: Maintain block device spec in separate directory Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 04/20] virtio-console: Maintain console " Parav Pandit
2023-01-01 18:08 ` [virtio-dev] [PATCH v1 05/20] virtio-entropy: Maintain entropy " Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 06/20] virtio-mem-balloon: Maintain mem balloon " Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 07/20] virtio-scsi: Maintain scsi host " Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 08/20] virtio-gpu: Maintain gpu " Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 09/20] virtio-input: Maintain input " Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 10/20] virtio-crypto: Maintain crypto " Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 11/20] virtio-vsock: Maintain socket " Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 12/20] virtio-fs: Maintain file system " Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 13/20] virtio-rpmb: Maintain rpmb " Parav Pandit
2023-01-09 12:48 ` Cornelia Huck
2023-01-09 13:35 ` Michael S. Tsirkin
2023-01-09 13:47 ` [virtio-dev] " Cornelia Huck
2023-01-09 13:53 ` Cornelia Huck
2023-01-09 14:13 ` Parav Pandit
2023-01-09 14:08 ` Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 14/20] virtio-iommu: Maintain iommu " Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 15/20] virtio-sound: Maintain sound " Parav Pandit
2023-01-09 13:05 ` [virtio-dev] " Cornelia Huck
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 16/20] virtio-mem: Maintain memory " Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 17/20] virtio-i2c: Maintain i2c " Parav Pandit
2023-01-09 13:07 ` [virtio-dev] " Cornelia Huck
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 18/20] virtio-scmi: Maintain scmi " Parav Pandit
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 19/20] virtio-gpio: Maintain gpio " Parav Pandit
2023-01-09 13:11 ` Cornelia Huck
2023-01-01 18:08 ` [virtio-comment] [PATCH v1 20/20] virtio-pmem: Maintain pmem " Parav Pandit
2023-01-03 10:47 ` [virtio-dev] Re: [PATCH v1 00/20] Split device spec to its individual files Michael S. Tsirkin
2023-01-03 14:15 ` [virtio-comment] " Parav Pandit
2023-01-03 14:19 ` [virtio-comment] " Michael S. Tsirkin
2023-01-03 14:26 ` [virtio-dev] " Parav Pandit
2023-01-03 15:43 ` [virtio-comment] " Michael S. Tsirkin
2023-01-03 16:04 ` [virtio-comment] " Parav Pandit
2023-01-03 16:19 ` [virtio-comment] " Michael S. Tsirkin
2023-01-03 16:41 ` [virtio-comment] " Parav Pandit
2023-01-03 16:52 ` [virtio-dev] " Michael S. Tsirkin
2023-01-03 18:00 ` [virtio-comment] " Parav Pandit
2023-01-03 11:01 ` [virtio-comment] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230109121558-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox