From: "Michael S. Tsirkin" <mst@redhat.com>
To: Heng Qi <hengqi@linux.alibaba.com>
Cc: "virtio-comment @ lists . oasis-open . org"
<virtio-comment@lists.oasis-open.org>,
"virtio-dev @ lists . oasis-open . org"
<virtio-dev@lists.oasis-open.org>,
Jason Wang <jasowang@redhat.com>, Parav Pandit <parav@nvidia.com>,
Alvaro Karsz <alvaro.karsz@solid-run.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: Re: [virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation
Date: Wed, 8 Feb 2023 05:10:02 -0500 [thread overview]
Message-ID: <20230208050822-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <98c2cd3f-2f59-74e1-0b37-cbf2a9180bd4@linux.alibaba.com>
On Wed, Feb 08, 2023 at 09:57:54AM +0800, Heng Qi wrote:
> > I think it's a good idea to do this on top of Alvaro's patch
> > unifying these two structures.
>
> I saw Alvaro's patch, but it doesn't seem to be stable yet, is there a good
> way for me to
> unify the two structures, since a patch should only do one thing.
Problem is you were trying to change these existing structures too
so the patches conflicted. However I think at this point
we are in agreement on a new command with a new structure.
In this case there won't be a conflict as you are
not touching existing commands so no need for you
to depend on Alvaro's patch.
--
MST
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-02-08 10:10 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 11:16 [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation Heng Qi
2023-02-07 11:25 ` [virtio-comment] " Alvaro Karsz
2023-02-07 11:50 ` Xuan Zhuo
2023-02-07 12:51 ` Parav Pandit
2023-02-07 14:29 ` [virtio-dev] " Michael S. Tsirkin
2023-02-07 14:40 ` Alvaro Karsz
2023-02-07 14:48 ` Michael S. Tsirkin
2023-02-07 14:56 ` Alvaro Karsz
2023-02-07 15:09 ` Michael S. Tsirkin
2023-02-07 15:25 ` Parav Pandit
2023-02-07 15:28 ` [virtio-comment] " Michael S. Tsirkin
2023-02-07 15:30 ` [virtio-comment] " Parav Pandit
2023-02-08 1:58 ` [virtio-comment] " Xuan Zhuo
2023-02-08 2:20 ` Heng Qi
2023-02-08 9:56 ` Michael S. Tsirkin
2023-02-08 13:51 ` Parav Pandit
2023-02-07 14:06 ` [virtio-comment] " Michael S. Tsirkin
2023-02-07 14:22 ` Michael S. Tsirkin
2023-02-08 1:45 ` Xuan Zhuo
2023-02-08 2:20 ` Parav Pandit
2023-02-08 2:24 ` Xuan Zhuo
2023-02-08 2:43 ` Parav Pandit
2023-02-08 10:07 ` Michael S. Tsirkin
2023-02-08 13:52 ` [virtio-dev] " Parav Pandit
2023-02-08 11:30 ` Heng Qi
2023-02-08 14:17 ` [virtio-dev] " Michael S. Tsirkin
2023-02-08 14:37 ` Parav Pandit
2023-02-08 14:42 ` [virtio-dev] " Michael S. Tsirkin
2023-02-08 14:44 ` Parav Pandit
2023-02-08 14:48 ` Michael S. Tsirkin
2023-02-08 15:04 ` Parav Pandit
2023-02-08 15:20 ` Michael S. Tsirkin
2023-02-08 15:27 ` Parav Pandit
2023-02-08 19:23 ` [virtio-dev] " Parav Pandit
2023-02-08 20:48 ` Michael S. Tsirkin
2023-02-08 17:53 ` Alvaro Karsz
2023-02-08 20:52 ` Michael S. Tsirkin
2023-02-08 21:05 ` Parav Pandit
2023-02-08 21:55 ` [virtio-dev] " Alvaro Karsz
2023-02-08 22:08 ` Parav Pandit
2023-02-08 22:15 ` [virtio-dev] " Michael S. Tsirkin
2023-02-08 22:23 ` Parav Pandit
2023-02-08 22:29 ` [virtio-dev] " Michael S. Tsirkin
2023-02-08 22:33 ` Parav Pandit
2023-02-08 22:45 ` Alvaro Karsz
2023-02-08 22:53 ` Michael S. Tsirkin
2023-02-08 22:35 ` [virtio-dev] " Alvaro Karsz
2023-02-08 22:57 ` Michael S. Tsirkin
2023-02-09 0:06 ` Parav Pandit
2023-02-09 3:16 ` [virtio-comment] Re: [virtio-dev] " Heng Qi
2023-02-08 22:13 ` Michael S. Tsirkin
2023-02-08 21:22 ` Alvaro Karsz
2023-02-09 3:25 ` Heng Qi
2023-02-09 3:12 ` [virtio-comment] Re: [virtio-dev] " Heng Qi
2023-02-09 3:28 ` [virtio-comment] Re: [virtio-dev] " Heng Qi
2023-02-08 14:44 ` Michael S. Tsirkin
2023-02-08 2:27 ` Xuan Zhuo
2023-02-08 2:35 ` [virtio-comment] Re: [virtio-dev] " Heng Qi
2023-02-08 2:47 ` [virtio-comment] " Parav Pandit
2023-02-08 1:57 ` [virtio-comment] Re: [virtio-dev] " Heng Qi
2023-02-08 10:04 ` Michael S. Tsirkin
2023-02-08 11:23 ` Heng Qi
2023-02-08 13:39 ` [virtio-dev] " Michael S. Tsirkin
2023-02-08 10:10 ` Michael S. Tsirkin [this message]
2023-02-08 11:24 ` Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230208050822-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alvaro.karsz@solid-run.com \
--cc=hengqi@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=parav@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox