From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alvaro Karsz <alvaro.karsz@solid-run.com>
Cc: virtio-comment@lists.oasis-open.org,
virtio-dev@lists.oasis-open.org, jasowang@redhat.com,
hengqi@linux.alibaba.com, parav@nvidia.com,
david.edmondson@oracle.com
Subject: [virtio-dev] Re: [PATCH v5] virtio-net: Fix and update VIRTIO_NET_F_NOTF_COAL feature
Date: Fri, 17 Feb 2023 05:57:48 -0500 [thread overview]
Message-ID: <20230217055700-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAJs=3_B-q6NbtNTqZuwyHn6eENYb+NpUijDXvnwW55bBYQcyGg@mail.gmail.com>
On Fri, Feb 17, 2023 at 12:36:32PM +0200, Alvaro Karsz wrote:
> > sounds good. maybe "counting packets and microseconds"? to make clear
> > timer resets too.
> >
> > > I don't really mind, If you think that the device implementation is
> > > not essential here and we should add your suggestion, I'm ok with
> > > that.
> >
> > I don't mind, your proposal seems good too.
>
> Ok, so I'll add:
> "... whichever happens first.
> After the notification conditions are met,
maybe just "afterwards" for brevity and to stress it is after sending interrupt
so it does not affect the interrupt only the next one.
> the device waits for the
> next packet and starts counting packets and microseconds again."
>
> Thanks!
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
prev parent reply other threads:[~2023-02-17 10:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 14:56 [virtio-dev] [PATCH v5] virtio-net: Fix and update VIRTIO_NET_F_NOTF_COAL feature Alvaro Karsz
2023-02-17 2:54 ` [virtio-comment] " Parav Pandit
2023-02-17 9:44 ` [virtio-comment] " Michael S. Tsirkin
2023-02-17 10:21 ` [virtio-dev] " Alvaro Karsz
2023-02-17 10:29 ` [virtio-comment] " Michael S. Tsirkin
2023-02-17 10:36 ` Alvaro Karsz
2023-02-17 10:57 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230217055700-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alvaro.karsz@solid-run.com \
--cc=david.edmondson@oracle.com \
--cc=hengqi@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=parav@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox