Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: Parav Pandit <parav@nvidia.com>
To: mst@redhat.com, virtio-dev@lists.oasis-open.org, cohuck@redhat.com
Cc: virtio-comment@lists.oasis-open.org, shahafs@nvidia.com,
	Parav Pandit <parav@nvidia.com>
Subject: [PATCH 0/3] Rename queue index to queue number
Date: Thu, 23 Feb 2023 07:46:21 +0200	[thread overview]
Message-ID: <20230223054624.168042-1-parav@nvidia.com> (raw)

1. Currently, virtqueue is identified between driver and device
interchangeably using either number of index terminology.

2. Between PCI and MMIO transport the queue size (depth) is
defined as queue_size and QueueNum respectively.

To avoid confusion and to have consistency, unify them to use as Number.

Solution:
Use virtqueue number description, and rename MMIO register as QueueSize.

Patch summary:
patch-1 renames index to number for pci transport
patch-2 renames mmio register from Num to Size
patch-3 renames index to number for mmio transport

Please review.
This series fixes the issue [1].

This series is on top of [2].

[1] https://github.com/oasis-tcs/virtio-spec/issues/163
[2] https://lists.oasis-open.org/archives/virtio-dev/202302/msg00527.html

---
Cornelia:
I was not sure about ccw for vq_config_block and vq_info_block structures
index field refers to the queue number or not.
Can you please clarify?

If it vqn, I will send v1 by replacing index to vqn to be
consistent with other part of the spec which also uses vqn.

Parav Pandit (3):
  transport-pci: Refer to the vq by its number
  transport-mmio: Rename QueueNum register
  transport-mmio: Refer to the vq by its number

 transport-mmio.tex | 16 ++++++++--------
 transport-pci.tex  |  6 +++---
 2 files changed, 11 insertions(+), 11 deletions(-)

-- 
2.26.2


             reply	other threads:[~2023-02-23  5:46 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-23  5:46 Parav Pandit [this message]
2023-02-23  5:46 ` [PATCH 1/3] transport-pci: Refer to the vq by its number Parav Pandit
2023-02-24 10:05   ` [virtio-dev] " Jiri Pirko
2023-02-23  5:46 ` [PATCH 2/3] transport-mmio: Rename QueueNum register Parav Pandit
2023-02-24 10:06   ` [virtio-dev] " Jiri Pirko
2023-02-27 17:36   ` Michael S. Tsirkin
2023-02-27 17:36     ` [virtio-dev] " Michael S. Tsirkin
2023-02-23  5:46 ` [PATCH 3/3] transport-mmio: Refer to the vq by its number Parav Pandit
2023-02-24 10:06   ` [virtio-dev] " Jiri Pirko
2023-02-27  8:45 ` [virtio-comment] Re: [PATCH 0/3] Rename queue index to queue number Cornelia Huck
2023-02-27  8:45   ` [virtio-dev] " Cornelia Huck
2023-02-27 16:00   ` Parav Pandit
2023-02-27 16:00     ` [virtio-dev] " Parav Pandit
2023-02-27 17:33     ` [virtio-dev] " Michael S. Tsirkin
2023-03-01 17:22   ` [virtio-dev] Re: [virtio-comment] " Halil Pasic
2023-03-01 17:37     ` Michael S. Tsirkin
2023-03-02 13:42       ` [virtio-dev] " Parav Pandit
2023-03-02 15:06       ` [virtio-dev] " Cornelia Huck
2023-03-02 15:58         ` Halil Pasic
2023-03-03  7:42         ` Michael S. Tsirkin
2023-03-03 21:49           ` Halil Pasic
2023-03-05  9:51             ` Michael S. Tsirkin
2023-03-09 16:46               ` Halil Pasic
2023-03-09 16:53                 ` Michael S. Tsirkin
2023-03-10 14:05                   ` Halil Pasic
2023-02-27 17:39 ` Michael S. Tsirkin
2023-02-27 17:39   ` [virtio-dev] " Michael S. Tsirkin
2023-03-02 15:52   ` [virtio-dev] Re: [virtio-comment] " Halil Pasic
2023-03-02 16:12     ` [virtio-dev] " Parav Pandit
2023-03-02 23:38       ` [virtio-dev] " Michael S. Tsirkin
2023-03-07 15:20         ` [virtio-dev] " Parav Pandit
2023-03-03 15:38       ` [virtio-dev] " Halil Pasic
2023-03-05  9:29         ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230223054624.168042-1-parav@nvidia.com \
    --to=parav@nvidia.com \
    --cc=cohuck@redhat.com \
    --cc=mst@redhat.com \
    --cc=shahafs@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox