Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: Parav Pandit <parav@nvidia.com>
To: mst@redhat.com, virtio-dev@lists.oasis-open.org, cohuck@redhat.com
Cc: virtio-comment@lists.oasis-open.org, shahafs@nvidia.com,
	Parav Pandit <parav@nvidia.com>
Subject: [PATCH 1/3] transport-pci: Refer to the vq by its number
Date: Thu, 23 Feb 2023 07:46:22 +0200	[thread overview]
Message-ID: <20230223054624.168042-2-parav@nvidia.com> (raw)
In-Reply-To: <20230223054624.168042-1-parav@nvidia.com>

Currently specification uses virtqueue index and
number interchangeably to refer to the virtqueue.

Instead refer to it by its number.

This patch is on top of [1].

[1] https://lists.oasis-open.org/archives/virtio-dev/202302/msg00527.html

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
 transport-pci.tex | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/transport-pci.tex b/transport-pci.tex
index da1486a..c9e112a 100644
--- a/transport-pci.tex
+++ b/transport-pci.tex
@@ -1005,7 +1005,7 @@ \subsubsection{Device Initialization}\label{sec:Virtio Transport Options / Virti
 The driver typically does this as follows, for each virtqueue a device has:
 
 \begin{enumerate}
-\item Write the virtqueue index (first queue is 0) to \field{queue_select}.
+\item Write the virtqueue number (first queue is 0) to \field{queue_select}.
 
 \item Read the virtqueue size from \field{queue_size}. This controls how big the virtqueue is
   (see \ref{sec:Basic Facilities of a Virtio Device / Virtqueues}~\nameref{sec:Basic Facilities of a Virtio Device / Virtqueues}). If this field is 0, the virtqueue does not exist.
@@ -1035,7 +1035,7 @@ \subsubsection{Available Buffer Notifications}\label{sec:Virtio Transport Option
 
 When VIRTIO_F_NOTIFICATION_DATA has not been negotiated,
 the driver sends an available buffer notification to the device by writing
-the 16-bit virtqueue index
+the 16-bit virtqueue number
 of this virtqueue to the Queue Notify address.
 
 When VIRTIO_F_NOTIFICATION_DATA has been negotiated,
@@ -1053,7 +1053,7 @@ \subsubsection{Available Buffer Notifications}\label{sec:Virtio Transport Option
 If VIRTIO_F_NOTIF_CONFIG_DATA has been negotiated:
 \begin{itemize}
 \item If VIRTIO_F_NOTIFICATION_DATA has not been negotiated, the driver MUST use the
-\field{queue_notify_data} value instead of the virtqueue index.
+\field{queue_notify_data} value instead of the virtqueue number.
 \item If VIRTIO_F_NOTIFICATION_DATA has been negotiated, the driver MUST set the
 \field{vqn} field to the \field{queue_notify_data} value.
 \end{itemize}
-- 
2.26.2


  reply	other threads:[~2023-02-23  5:46 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-23  5:46 [PATCH 0/3] Rename queue index to queue number Parav Pandit
2023-02-23  5:46 ` Parav Pandit [this message]
2023-02-24 10:05   ` [virtio-dev] [PATCH 1/3] transport-pci: Refer to the vq by its number Jiri Pirko
2023-02-23  5:46 ` [PATCH 2/3] transport-mmio: Rename QueueNum register Parav Pandit
2023-02-24 10:06   ` [virtio-dev] " Jiri Pirko
2023-02-27 17:36   ` Michael S. Tsirkin
2023-02-27 17:36     ` [virtio-dev] " Michael S. Tsirkin
2023-02-23  5:46 ` [PATCH 3/3] transport-mmio: Refer to the vq by its number Parav Pandit
2023-02-24 10:06   ` [virtio-dev] " Jiri Pirko
2023-02-27  8:45 ` [virtio-comment] Re: [PATCH 0/3] Rename queue index to queue number Cornelia Huck
2023-02-27  8:45   ` [virtio-dev] " Cornelia Huck
2023-02-27 16:00   ` Parav Pandit
2023-02-27 16:00     ` [virtio-dev] " Parav Pandit
2023-02-27 17:33     ` [virtio-dev] " Michael S. Tsirkin
2023-03-01 17:22   ` [virtio-dev] Re: [virtio-comment] " Halil Pasic
2023-03-01 17:37     ` Michael S. Tsirkin
2023-03-02 13:42       ` [virtio-dev] " Parav Pandit
2023-03-02 15:06       ` [virtio-dev] " Cornelia Huck
2023-03-02 15:58         ` Halil Pasic
2023-03-03  7:42         ` Michael S. Tsirkin
2023-03-03 21:49           ` Halil Pasic
2023-03-05  9:51             ` Michael S. Tsirkin
2023-03-09 16:46               ` Halil Pasic
2023-03-09 16:53                 ` Michael S. Tsirkin
2023-03-10 14:05                   ` Halil Pasic
2023-02-27 17:39 ` Michael S. Tsirkin
2023-02-27 17:39   ` [virtio-dev] " Michael S. Tsirkin
2023-03-02 15:52   ` [virtio-dev] Re: [virtio-comment] " Halil Pasic
2023-03-02 16:12     ` [virtio-dev] " Parav Pandit
2023-03-02 23:38       ` [virtio-dev] " Michael S. Tsirkin
2023-03-07 15:20         ` [virtio-dev] " Parav Pandit
2023-03-03 15:38       ` [virtio-dev] " Halil Pasic
2023-03-05  9:29         ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230223054624.168042-2-parav@nvidia.com \
    --to=parav@nvidia.com \
    --cc=cohuck@redhat.com \
    --cc=mst@redhat.com \
    --cc=shahafs@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox