Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: Parav Pandit <parav@nvidia.com>
To: mst@redhat.com, virtio-dev@lists.oasis-open.org, cohuck@redhat.com
Cc: virtio-comment@lists.oasis-open.org, shahafs@nvidia.com,
	Parav Pandit <parav@nvidia.com>
Subject: [PATCH 2/3] transport-pci: Split notes of PCI Device Layout
Date: Sun, 26 Feb 2023 00:30:00 +0200	[thread overview]
Message-ID: <20230225223001.430522-3-parav@nvidia.com> (raw)
In-Reply-To: <20230225223001.430522-1-parav@nvidia.com>

Currently single legacy interface section describes PCI common
configuration layout and feature bits operation for the
legacy interface.
Secondly common configuration structure description of legacy interface
is not adjacent to the the respective normal device requirements for
same.

Hence, split PCI Device Layout legacy interface section into two
parts. First subsection for common configuration and second
subsection for feature bits.

Subsequent patch relocates common configuration legacy interface to
appropriate matching location.

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/164
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
 conformance.tex   |  4 +++-
 transport-pci.tex | 19 ++++++++++++-------
 2 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/conformance.tex b/conformance.tex
index 01ccd69..0d3616f 100644
--- a/conformance.tex
+++ b/conformance.tex
@@ -262,7 +262,9 @@ \section{Conformance Targets}\label{sec:Conformance / Conformance Targets}
 \item Section \ref{sec:Basic Facilities of a Virtio Device / Virtqueues / Message Framing / Legacy Interface: Message Framing}
 \item Section \ref{sec:General Initialization And Device Operation / Device Initialization / Legacy Interface: Device Initialization}
 \item Section \ref{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI Device Discovery / Legacy Interfaces: A Note on PCI Device Discovery}
-\item Section \ref{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI Device Layout / Legacy Interfaces: A Note on PCI Device Layout}
+\item Section \ref{sec:Virtio Transport Options / Virtio Over PCI Bus/ Virtio Structure PCI Capabilities / Legacy Interfaces: A Note on Common
+configuration Layout}
+\item Section \ref{sec:Virtio Transport Options / Virtio Over PCI Bus / Virtio Structure PCI Capabilities / Legacy Interface: A Note on feature bits}
 \item Section \ref{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI-specific Initialization And Device Operation / Device Initialization / Virtio Device Configuration Layout Detection / Legacy Interface: A Note on Device Layout Detection}
 \item Section \ref{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI-specific Initialization And Device Operation / Device Initialization / Virtqueue Configuration / Legacy Interface: A Note on Virtqueue Configuration}
 \item Section \ref{sec:Virtio Transport Options / Virtio Over MMIO / Legacy interface}
diff --git a/transport-pci.tex b/transport-pci.tex
index 9ee37ba..9d4c713 100644
--- a/transport-pci.tex
+++ b/transport-pci.tex
@@ -767,7 +767,10 @@ \subsubsection{PCI configuration access capability}\label{sec:Virtio Transport O
 specified by some other Virtio Structure PCI Capability
 of type other than \field{VIRTIO_PCI_CAP_PCI_CFG}.
 
-\subsubsection{Legacy Interfaces: A Note on PCI Device Layout}\label{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI Device Layout / Legacy Interfaces: A Note on PCI Device Layout}
+\subsubsection{Legacy Interfaces: A Note on Common configuration
+Layout}\label{sec:Virtio Transport Options / Virtio Over PCI Bus
+/ Virtio Structure PCI Capabilities / Legacy Interfaces: A Note on Common
+configuration Layout}
 
 The transitional device MUST present part of the configuration
 registers in a legacy configuration structure in BAR0 in the
@@ -852,13 +855,15 @@ \subsubsection{Legacy Interfaces: A Note on PCI Device Layout}\label{sec:Virtio
 is encoded in the native endian of the guest (where such
 distinction is applicable).
 
-When accessing the device-specific configuration structure
-using the legacy interface, transitional drivers MUST access
-the device-specific configuration structure
-at an offset immediately following the legacy common
-configuration structure.
+The transitional driver when using the legacy interface MUST
+the device-specific configuration structure at an offset
+immediately following the legacy common configuration structure.
 
-Note that only Feature Bits 0 to 31 are accessible through the
+\subsubsection{Legacy Interface: A Note on feature
+bits}\label{sec:Virtio Transport Options / Virtio Over PCI Bus /
+Virtio Structure PCI Capabilities / Legacy Interface: A Note on feature bits}
+
+Only Feature Bits 0 to 31 are accessible through the
 Legacy Interface. When used through the Legacy Interface,
 the transitional device MUST assume that Feature Bits 32 to 63
 are not acknowledged by the driver.
-- 
2.26.2


WARNING: multiple messages have this Message-ID (diff)
From: Parav Pandit <parav@nvidia.com>
To: <mst@redhat.com>, <virtio-dev@lists.oasis-open.org>, <cohuck@redhat.com>
Cc: <virtio-comment@lists.oasis-open.org>, <shahafs@nvidia.com>,
	Parav Pandit <parav@nvidia.com>
Subject: [virtio-dev] [PATCH 2/3] transport-pci: Split notes of PCI Device Layout
Date: Sun, 26 Feb 2023 00:30:00 +0200	[thread overview]
Message-ID: <20230225223001.430522-3-parav@nvidia.com> (raw)
Message-ID: <20230225223000.sn-9SRLVmBup81S-rgZRKvoPxXncYrcc4d5V2ZoMyKU@z> (raw)
In-Reply-To: <20230225223001.430522-1-parav@nvidia.com>

Currently single legacy interface section describes PCI common
configuration layout and feature bits operation for the
legacy interface.
Secondly common configuration structure description of legacy interface
is not adjacent to the the respective normal device requirements for
same.

Hence, split PCI Device Layout legacy interface section into two
parts. First subsection for common configuration and second
subsection for feature bits.

Subsequent patch relocates common configuration legacy interface to
appropriate matching location.

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/164
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
 conformance.tex   |  4 +++-
 transport-pci.tex | 19 ++++++++++++-------
 2 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/conformance.tex b/conformance.tex
index 01ccd69..0d3616f 100644
--- a/conformance.tex
+++ b/conformance.tex
@@ -262,7 +262,9 @@ \section{Conformance Targets}\label{sec:Conformance / Conformance Targets}
 \item Section \ref{sec:Basic Facilities of a Virtio Device / Virtqueues / Message Framing / Legacy Interface: Message Framing}
 \item Section \ref{sec:General Initialization And Device Operation / Device Initialization / Legacy Interface: Device Initialization}
 \item Section \ref{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI Device Discovery / Legacy Interfaces: A Note on PCI Device Discovery}
-\item Section \ref{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI Device Layout / Legacy Interfaces: A Note on PCI Device Layout}
+\item Section \ref{sec:Virtio Transport Options / Virtio Over PCI Bus/ Virtio Structure PCI Capabilities / Legacy Interfaces: A Note on Common
+configuration Layout}
+\item Section \ref{sec:Virtio Transport Options / Virtio Over PCI Bus / Virtio Structure PCI Capabilities / Legacy Interface: A Note on feature bits}
 \item Section \ref{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI-specific Initialization And Device Operation / Device Initialization / Virtio Device Configuration Layout Detection / Legacy Interface: A Note on Device Layout Detection}
 \item Section \ref{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI-specific Initialization And Device Operation / Device Initialization / Virtqueue Configuration / Legacy Interface: A Note on Virtqueue Configuration}
 \item Section \ref{sec:Virtio Transport Options / Virtio Over MMIO / Legacy interface}
diff --git a/transport-pci.tex b/transport-pci.tex
index 9ee37ba..9d4c713 100644
--- a/transport-pci.tex
+++ b/transport-pci.tex
@@ -767,7 +767,10 @@ \subsubsection{PCI configuration access capability}\label{sec:Virtio Transport O
 specified by some other Virtio Structure PCI Capability
 of type other than \field{VIRTIO_PCI_CAP_PCI_CFG}.
 
-\subsubsection{Legacy Interfaces: A Note on PCI Device Layout}\label{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI Device Layout / Legacy Interfaces: A Note on PCI Device Layout}
+\subsubsection{Legacy Interfaces: A Note on Common configuration
+Layout}\label{sec:Virtio Transport Options / Virtio Over PCI Bus
+/ Virtio Structure PCI Capabilities / Legacy Interfaces: A Note on Common
+configuration Layout}
 
 The transitional device MUST present part of the configuration
 registers in a legacy configuration structure in BAR0 in the
@@ -852,13 +855,15 @@ \subsubsection{Legacy Interfaces: A Note on PCI Device Layout}\label{sec:Virtio
 is encoded in the native endian of the guest (where such
 distinction is applicable).
 
-When accessing the device-specific configuration structure
-using the legacy interface, transitional drivers MUST access
-the device-specific configuration structure
-at an offset immediately following the legacy common
-configuration structure.
+The transitional driver when using the legacy interface MUST
+the device-specific configuration structure at an offset
+immediately following the legacy common configuration structure.
 
-Note that only Feature Bits 0 to 31 are accessible through the
+\subsubsection{Legacy Interface: A Note on feature
+bits}\label{sec:Virtio Transport Options / Virtio Over PCI Bus /
+Virtio Structure PCI Capabilities / Legacy Interface: A Note on feature bits}
+
+Only Feature Bits 0 to 31 are accessible through the
 Legacy Interface. When used through the Legacy Interface,
 the transitional device MUST assume that Feature Bits 32 to 63
 are not acknowledged by the driver.
-- 
2.26.2


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  parent reply	other threads:[~2023-02-25 22:30 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-25 22:29 [PATCH 0/3] Cleanup for PCI transitional common cfg Parav Pandit
2023-02-25 22:29 ` [virtio-dev] " Parav Pandit
2023-02-25 22:29 ` [PATCH 1/3] transport-pci: Improve PCI legacy device layout description Parav Pandit
2023-02-25 22:29   ` [virtio-dev] " Parav Pandit
2023-02-25 23:08   ` Michael S. Tsirkin
2023-02-25 23:08     ` [virtio-dev] " Michael S. Tsirkin
2023-02-27  3:02     ` Parav Pandit
2023-02-27  3:02       ` [virtio-dev] " Parav Pandit
2023-02-27  7:34       ` Michael S. Tsirkin
2023-02-27  7:34         ` [virtio-dev] " Michael S. Tsirkin
2023-02-25 22:30 ` Parav Pandit [this message]
2023-02-25 22:30   ` [virtio-dev] [PATCH 2/3] transport-pci: Split notes of PCI Device Layout Parav Pandit
2023-02-25 23:15   ` Michael S. Tsirkin
2023-02-25 23:15     ` [virtio-dev] " Michael S. Tsirkin
2023-02-27  3:05     ` Parav Pandit
2023-02-27  3:05       ` [virtio-dev] " Parav Pandit
2023-02-27  7:35       ` [virtio-dev] " Michael S. Tsirkin
2023-02-25 22:30 ` [PATCH 3/3] transport-pci: Relocate common config legacy interface Parav Pandit
2023-02-25 22:30   ` [virtio-dev] " Parav Pandit
2023-02-25 23:16   ` Michael S. Tsirkin
2023-02-25 23:16     ` [virtio-dev] " Michael S. Tsirkin
2023-02-27  3:07     ` Parav Pandit
2023-02-27  3:07       ` [virtio-dev] " Parav Pandit
2023-02-25 23:17 ` [PATCH 0/3] Cleanup for PCI transitional common cfg Michael S. Tsirkin
2023-02-25 23:17   ` [virtio-dev] " Michael S. Tsirkin
2023-02-27  8:59   ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230225223001.430522-3-parav@nvidia.com \
    --to=parav@nvidia.com \
    --cc=cohuck@redhat.com \
    --cc=mst@redhat.com \
    --cc=shahafs@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox