Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: virtio-dev@lists.oasis-open.org, cohuck@redhat.com,
	virtio-comment@lists.oasis-open.org, shahafs@nvidia.com
Subject: [virtio-dev] Re: [PATCH] transport-pci: Remove duplicate word structure
Date: Sat, 11 Mar 2023 16:17:44 -0500	[thread overview]
Message-ID: <20230311161641-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230310150620.115188-1-parav@nvidia.com>

On Fri, Mar 10, 2023 at 05:06:20PM +0200, Parav Pandit wrote:
> Remove duplicate word structure.
> 
> Signed-off-by: Parav Pandit <parav@nvidia.com>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

a minor cleanup, Cornelia can you commit?

> ---
>  transport-pci.tex | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/transport-pci.tex b/transport-pci.tex
> index 01fb652..b07a822 100644
> --- a/transport-pci.tex
> +++ b/transport-pci.tex
> @@ -813,7 +813,7 @@ \subsubsection{Legacy Interfaces: A Note on PCI Device Layout}\label{sec:Virtio
>  \end{tabular}
>  
>  Note: When MSI-X capability is enabled, device-specific configuration starts at
> -byte offset 24 in virtio common configuration structure structure. When MSI-X capability is not
> +byte offset 24 in virtio common configuration structure. When MSI-X capability is not
>  enabled, device-specific configuration starts at byte offset 20 in virtio
>  header.  ie. once you enable MSI-X on the device, the other fields move.
>  If you turn it off again, they move back!
> -- 
> 2.26.2


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  reply	other threads:[~2023-03-11 21:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10 15:06 [virtio-dev] [PATCH] transport-pci: Remove duplicate word structure Parav Pandit
2023-03-11 21:17 ` Michael S. Tsirkin [this message]
2023-03-13  8:49 ` [virtio-dev] Re: [virtio-comment] " Halil Pasic
2023-03-13 10:04 ` Jiri Pirko
2023-03-15 11:21 ` [virtio-dev] " Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230311161641-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=parav@nvidia.com \
    --cc=shahafs@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox