* [virtio-dev] [PATCH] transport-pci: Remove duplicate word structure
@ 2023-03-10 15:06 Parav Pandit
2023-03-11 21:17 ` [virtio-dev] " Michael S. Tsirkin
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Parav Pandit @ 2023-03-10 15:06 UTC (permalink / raw)
To: mst, virtio-dev, cohuck; +Cc: virtio-comment, shahafs, Parav Pandit
Remove duplicate word structure.
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
transport-pci.tex | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/transport-pci.tex b/transport-pci.tex
index 01fb652..b07a822 100644
--- a/transport-pci.tex
+++ b/transport-pci.tex
@@ -813,7 +813,7 @@ \subsubsection{Legacy Interfaces: A Note on PCI Device Layout}\label{sec:Virtio
\end{tabular}
Note: When MSI-X capability is enabled, device-specific configuration starts at
-byte offset 24 in virtio common configuration structure structure. When MSI-X capability is not
+byte offset 24 in virtio common configuration structure. When MSI-X capability is not
enabled, device-specific configuration starts at byte offset 20 in virtio
header. ie. once you enable MSI-X on the device, the other fields move.
If you turn it off again, they move back!
--
2.26.2
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [virtio-dev] Re: [PATCH] transport-pci: Remove duplicate word structure
2023-03-10 15:06 [virtio-dev] [PATCH] transport-pci: Remove duplicate word structure Parav Pandit
@ 2023-03-11 21:17 ` Michael S. Tsirkin
2023-03-13 8:49 ` [virtio-dev] Re: [virtio-comment] " Halil Pasic
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Michael S. Tsirkin @ 2023-03-11 21:17 UTC (permalink / raw)
To: Parav Pandit; +Cc: virtio-dev, cohuck, virtio-comment, shahafs
On Fri, Mar 10, 2023 at 05:06:20PM +0200, Parav Pandit wrote:
> Remove duplicate word structure.
>
> Signed-off-by: Parav Pandit <parav@nvidia.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
a minor cleanup, Cornelia can you commit?
> ---
> transport-pci.tex | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/transport-pci.tex b/transport-pci.tex
> index 01fb652..b07a822 100644
> --- a/transport-pci.tex
> +++ b/transport-pci.tex
> @@ -813,7 +813,7 @@ \subsubsection{Legacy Interfaces: A Note on PCI Device Layout}\label{sec:Virtio
> \end{tabular}
>
> Note: When MSI-X capability is enabled, device-specific configuration starts at
> -byte offset 24 in virtio common configuration structure structure. When MSI-X capability is not
> +byte offset 24 in virtio common configuration structure. When MSI-X capability is not
> enabled, device-specific configuration starts at byte offset 20 in virtio
> header. ie. once you enable MSI-X on the device, the other fields move.
> If you turn it off again, they move back!
> --
> 2.26.2
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* [virtio-dev] Re: [virtio-comment] [PATCH] transport-pci: Remove duplicate word structure
2023-03-10 15:06 [virtio-dev] [PATCH] transport-pci: Remove duplicate word structure Parav Pandit
2023-03-11 21:17 ` [virtio-dev] " Michael S. Tsirkin
@ 2023-03-13 8:49 ` Halil Pasic
2023-03-13 10:04 ` Jiri Pirko
2023-03-15 11:21 ` [virtio-dev] " Cornelia Huck
3 siblings, 0 replies; 5+ messages in thread
From: Halil Pasic @ 2023-03-13 8:49 UTC (permalink / raw)
To: Parav Pandit
Cc: mst, virtio-dev, cohuck, virtio-comment, shahafs, Halil Pasic
On Fri, 10 Mar 2023 17:06:20 +0200
Parav Pandit <parav@nvidia.com> wrote:
> Remove duplicate word structure.
>
> Signed-off-by: Parav Pandit <parav@nvidia.com>
Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* [virtio-dev] Re: [virtio-comment] [PATCH] transport-pci: Remove duplicate word structure
2023-03-10 15:06 [virtio-dev] [PATCH] transport-pci: Remove duplicate word structure Parav Pandit
2023-03-11 21:17 ` [virtio-dev] " Michael S. Tsirkin
2023-03-13 8:49 ` [virtio-dev] Re: [virtio-comment] " Halil Pasic
@ 2023-03-13 10:04 ` Jiri Pirko
2023-03-15 11:21 ` [virtio-dev] " Cornelia Huck
3 siblings, 0 replies; 5+ messages in thread
From: Jiri Pirko @ 2023-03-13 10:04 UTC (permalink / raw)
To: Parav Pandit; +Cc: mst, virtio-dev, cohuck, virtio-comment, shahafs
Fri, Mar 10, 2023 at 04:06:20PM CET, parav@nvidia.com wrote:
>Remove duplicate word structure.
>
>Signed-off-by: Parav Pandit <parav@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* [virtio-dev] Re: [PATCH] transport-pci: Remove duplicate word structure
2023-03-10 15:06 [virtio-dev] [PATCH] transport-pci: Remove duplicate word structure Parav Pandit
` (2 preceding siblings ...)
2023-03-13 10:04 ` Jiri Pirko
@ 2023-03-15 11:21 ` Cornelia Huck
3 siblings, 0 replies; 5+ messages in thread
From: Cornelia Huck @ 2023-03-15 11:21 UTC (permalink / raw)
To: Parav Pandit, mst, virtio-dev; +Cc: virtio-comment, shahafs, Parav Pandit
On Fri, Mar 10 2023, Parav Pandit <parav@nvidia.com> wrote:
> Remove duplicate word structure.
>
> Signed-off-by: Parav Pandit <parav@nvidia.com>
> ---
> transport-pci.tex | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, pushed as an editorial update.
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-03-15 11:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-10 15:06 [virtio-dev] [PATCH] transport-pci: Remove duplicate word structure Parav Pandit
2023-03-11 21:17 ` [virtio-dev] " Michael S. Tsirkin
2023-03-13 8:49 ` [virtio-dev] Re: [virtio-comment] " Halil Pasic
2023-03-13 10:04 ` Jiri Pirko
2023-03-15 11:21 ` [virtio-dev] " Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox