From: Thomas Zimmermann <tzimmermann@suse.de>
To: Dmitry Osipenko <dmitry.osipenko@collabora.com>,
airlied@redhat.com, kraxel@redhat.com, zack.rusin@broadcom.com,
airlied@gmail.com, daniel@ffwll.ch,
maarten.lankhorst@linux.intel.com, mripard@kernel.org
Cc: regressions@leemhuis.info, virtualization@lists.linux.dev,
spice-devel@lists.freedesktop.org,
dri-devel@lists.freedesktop.org,
"David Kaplan" <david.kaplan@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/qxl: Pin buffer objects for internal mappings
Date: Mon, 8 Jul 2024 14:11:21 +0200 [thread overview]
Message-ID: <0a83cfa5-8d25-4825-95ab-65d5e6ebd9ce@suse.de> (raw)
In-Reply-To: <b18c4505-efd2-403b-9bde-eed510c832f9@collabora.com>
Hi
Am 08.07.24 um 13:55 schrieb Dmitry Osipenko:
> On 7/2/24 17:20, Thomas Zimmermann wrote:
>> @@ -190,7 +190,13 @@ int qxl_bo_vmap(struct qxl_bo *bo, struct iosys_map *map)
>> if (r)
>> return r;
>>
>> + r = qxl_bo_pin_locked(bo);
>> + if (r)
>> + return r;
> Is qxl_bo_unreserve() missing here?
Yeah, indeed. Thanks for reporting.
Best regards
Thomas
>
>> +
>> r = qxl_bo_vmap_locked(bo, map);
>> + if (r)
>> + qxl_bo_unpin_locked(bo);
>> qxl_bo_unreserve(bo);
>> return r;
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
prev parent reply other threads:[~2024-07-08 12:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 14:20 [PATCH] drm/qxl: Pin buffer objects for internal mappings Thomas Zimmermann
2024-07-08 8:09 ` Thomas Zimmermann
2024-07-08 8:58 ` Daniel Vetter
2024-07-08 11:49 ` Thomas Zimmermann
2024-07-08 11:55 ` Dmitry Osipenko
2024-07-08 12:11 ` Thomas Zimmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a83cfa5-8d25-4825-95ab-65d5e6ebd9ce@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=david.kaplan@amd.com \
--cc=dmitry.osipenko@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=regressions@leemhuis.info \
--cc=spice-devel@lists.freedesktop.org \
--cc=virtualization@lists.linux.dev \
--cc=zack.rusin@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox