From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
airlied@redhat.com, kraxel@redhat.com, zack.rusin@broadcom.com,
airlied@gmail.com, daniel@ffwll.ch,
maarten.lankhorst@linux.intel.com, mripard@kernel.org
Cc: regressions@leemhuis.info, virtualization@lists.linux.dev,
spice-devel@lists.freedesktop.org,
dri-devel@lists.freedesktop.org,
"David Kaplan" <david.kaplan@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/qxl: Pin buffer objects for internal mappings
Date: Mon, 8 Jul 2024 14:55:04 +0300 [thread overview]
Message-ID: <b18c4505-efd2-403b-9bde-eed510c832f9@collabora.com> (raw)
In-Reply-To: <20240702142034.32615-1-tzimmermann@suse.de>
On 7/2/24 17:20, Thomas Zimmermann wrote:
> @@ -190,7 +190,13 @@ int qxl_bo_vmap(struct qxl_bo *bo, struct iosys_map *map)
> if (r)
> return r;
>
> + r = qxl_bo_pin_locked(bo);
> + if (r)
> + return r;
Is qxl_bo_unreserve() missing here?
> +
> r = qxl_bo_vmap_locked(bo, map);
> + if (r)
> + qxl_bo_unpin_locked(bo);
> qxl_bo_unreserve(bo);
> return r;
--
Best regards,
Dmitry
next prev parent reply other threads:[~2024-07-08 11:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 14:20 [PATCH] drm/qxl: Pin buffer objects for internal mappings Thomas Zimmermann
2024-07-08 8:09 ` Thomas Zimmermann
2024-07-08 8:58 ` Daniel Vetter
2024-07-08 11:49 ` Thomas Zimmermann
2024-07-08 11:55 ` Dmitry Osipenko [this message]
2024-07-08 12:11 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b18c4505-efd2-403b-9bde-eed510c832f9@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=david.kaplan@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=regressions@leemhuis.info \
--cc=spice-devel@lists.freedesktop.org \
--cc=tzimmermann@suse.de \
--cc=virtualization@lists.linux.dev \
--cc=zack.rusin@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox