Slackware-11.0, Kernel-2.6.20, lguest-137.patch : compiling problem

Slackware-11.0, Kernel-2.6.20, lguest-137.patch : compiling problem

[Strelenko Yuri A]

  Please, explain me, what is the problem in compiling kernel-2.6.20
patched with lguest-137.patch in Slackware-11.0:

  LD [M]  drivers/kvm/kvm-intel.o
  LD [M]  drivers/kvm/kvm-amd.o
  CC      drivers/lguest/lguest_bus.o
  LD      drivers/lguest/built-in.o
  AS [M]  drivers/lguest/hypervisor.o
drivers/lguest/hypervisor.S: Assembler messages:
drivers/lguest/hypervisor.S:162: Error: bad expression
drivers/lguest/hypervisor.S:162: Error: missing ')'
drivers/lguest/hypervisor.S:162: Error: junk at end of line, first
unrecognized character is `2' drivers/lguest/hypervisor.S:162: Error:
bad expression drivers/lguest/hypervisor.S:162: Error: missing ')'
drivers/lguest/hypervisor.S:162: Error: junk at end of line, first
unrecognized character is `2'
   and so on ....

	With best wishes and kind regards, Yuri Strelenko.

-- 
===================================================================
Dr. Yuri A. Strelenko	
N.D.Zelinsky Institute of Organic Chemistry
Leninsky prospect 47,119991 Moscow, Russia 
Tel    :      (7-095) 135 9094
Fax    :      (7-095) 135 5328
e-mail :      strel@ioc.ac.ru 
www    :      http://nmr.ioc.ac.ru
GPG-Key: http://nmr.ioc.ac.ru/Staff/StrelenkoYA/GnuPG/Strelenko.gpg
===================================================================

Re: Slackware-11.0, Kernel-2.6.20, lguest-137.patch : compiling problem

[Rusty Russell]

On Wed, 2007-02-07 at 17:44 +0300, Strelenko Yuri A wrote:
>   Please, explain me, what is the problem in compiling kernel-2.6.20
> patched with lguest-137.patch in Slackware-11.0:
> 
>   LD [M]  drivers/kvm/kvm-intel.o
>   LD [M]  drivers/kvm/kvm-amd.o
>   CC      drivers/lguest/lguest_bus.o
>   LD      drivers/lguest/built-in.o
>   AS [M]  drivers/lguest/hypervisor.o
> drivers/lguest/hypervisor.S: Assembler messages:
> drivers/lguest/hypervisor.S:162: Error: bad expression
> drivers/lguest/hypervisor.S:162: Error: missing ')'
> drivers/lguest/hypervisor.S:162: Error: junk at end of line, first
> unrecognized character is `2' drivers/lguest/hypervisor.S:162: Error:
> bad expression drivers/lguest/hypervisor.S:162: Error: missing ')'
> drivers/lguest/hypervisor.S:162: Error: junk at end of line, first
> unrecognized character is `2'

Hi Yuri!

	Hmm, this is very odd.  Looks like it's barfing on the IRQ_STUB macro.
Can you do two things for me?

1) Please confirm that your line 162 is:
	IRQ_STUBS 0 1 return_to_host		/* First two traps */

2) Then please send me the output of "as --version", eg:
	GNU assembler 2.17 Debian GNU/Linux

Perhaps I accidentally used a new gas feature?

Thanks!
Rusty.

Re: Slackware-11.0, Kernel-2.6.20, lguest-137.patch : compiling problem

[Rusty Russell]

On Thu, 2007-02-08 at 10:54 +1100, Rusty Russell wrote:
> Perhaps I accidentally used a new gas feature?

OK, I grabbed slackware 11's binutils, and != wasn't valid in .if
expressions in binutils 2.15.  "<>" is more portable.

Fixed and pushed: thanks for the report!
Rusty.