* Re: [PATCH net 3/3] virtio-net: enable TSO/checksum offloads for Q-in-Q vlans
2017-05-18 13:31 ` [PATCH net 3/3] virtio-net: enable TSO/checksum offloads for Q-in-Q vlans Vladislav Yasevich
@ 2017-05-18 15:06 ` Michael S. Tsirkin
2017-05-19 14:18 ` Jason Wang
1 sibling, 0 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2017-05-18 15:06 UTC (permalink / raw)
To: Vladislav Yasevich; +Cc: netdev, virtualization
On Thu, May 18, 2017 at 09:31:05AM -0400, Vladislav Yasevich wrote:
> Since virtio does not provide it's own ndo_features_check handler,
> TSO, and now checksum offload, are disabled for stacked vlans.
> Re-enable the support and let the host take care of it. This
> restores/improves Guest-to-Guest performance over Q-in-Q vlans.
>
> CC: "Michael S. Tsirkin" <mst@redhat.com>
> CC: Jason Wang <jasowang@redhat.com>
> CC: virtualization@lists.linux-foundation.org
> Signed-off-by: Vladislav Yasevich <vyasevic@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/net/virtio_net.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 8324a5e..341fb96 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -2028,6 +2028,7 @@ static const struct net_device_ops virtnet_netdev = {
> .ndo_poll_controller = virtnet_netpoll,
> #endif
> .ndo_xdp = virtnet_xdp,
> + .ndo_features_check = passthru_features_check,
> };
>
> static void virtnet_config_changed_work(struct work_struct *work)
> --
> 2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net 3/3] virtio-net: enable TSO/checksum offloads for Q-in-Q vlans
2017-05-18 13:31 ` [PATCH net 3/3] virtio-net: enable TSO/checksum offloads for Q-in-Q vlans Vladislav Yasevich
2017-05-18 15:06 ` Michael S. Tsirkin
@ 2017-05-19 14:18 ` Jason Wang
1 sibling, 0 replies; 3+ messages in thread
From: Jason Wang @ 2017-05-19 14:18 UTC (permalink / raw)
To: Vladislav Yasevich, netdev; +Cc: virtualization, Michael S. Tsirkin
On 2017年05月18日 21:31, Vladislav Yasevich wrote:
> Since virtio does not provide it's own ndo_features_check handler,
> TSO, and now checksum offload, are disabled for stacked vlans.
> Re-enable the support and let the host take care of it. This
> restores/improves Guest-to-Guest performance over Q-in-Q vlans.
>
> CC: "Michael S. Tsirkin" <mst@redhat.com>
> CC: Jason Wang <jasowang@redhat.com>
> CC: virtualization@lists.linux-foundation.org
> Signed-off-by: Vladislav Yasevich <vyasevic@redhat.com>
> ---
> drivers/net/virtio_net.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 8324a5e..341fb96 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -2028,6 +2028,7 @@ static const struct net_device_ops virtnet_netdev = {
> .ndo_poll_controller = virtnet_netpoll,
> #endif
> .ndo_xdp = virtnet_xdp,
> + .ndo_features_check = passthru_features_check,
> };
>
> static void virtnet_config_changed_work(struct work_struct *work)
Acked-by: Jason Wang <jasowang@redhat.com>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 3+ messages in thread