Linux virtualization list
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: akpm <akpm@linux-foundation.org>,
	xen-devel@lists.xensource.com,
	Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] xen: fix p2m section mismatches
Date: Thu, 24 Mar 2011 14:48:02 -0700	[thread overview]
Message-ID: <20110324144802.1def1400@nehalam> (raw)
In-Reply-To: <20110324133432.544092e4.randy.dunlap@oracle.com>

On Thu, 24 Mar 2011 13:34:32 -0700
Randy Dunlap <randy.dunlap@oracle.com> wrote:

> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Fix section mismatch warnings:
> set_phys_range_identity() is called by __init xen_set_identity(),
> so also mark set_phys_range_identity() as __init.
> then:
> __early_alloc_p2m() is called set_phys_range_identity(), so also mark
> __early_alloc_p2m() as __init.
> 
> WARNING: arch/x86/built-in.o(.text+0x7856): Section mismatch in reference from the function __early_alloc_p2m() to the function .init.text:extend_brk()
> The function __early_alloc_p2m() references
> the function __init extend_brk().
> This is often because __early_alloc_p2m lacks a __init 
> annotation or the annotation of extend_brk is wrong.
> 
> WARNING: arch/x86/built-in.o(.text+0x7967): Section mismatch in reference from the function set_phys_range_identity() to the function .init.text:extend_brk()
> The function set_phys_range_identity() references
> the function __init extend_brk().
> This is often because set_phys_range_identity lacks a __init 
> annotation or the annotation of extend_brk is wrong.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  arch/x86/xen/p2m.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- linux-2.6.38-git13.orig/arch/x86/xen/p2m.c
> +++ linux-2.6.38-git13/arch/x86/xen/p2m.c
> @@ -497,7 +497,7 @@ static bool alloc_p2m(unsigned long pfn)
>  	return true;
>  }
>  
> -bool __early_alloc_p2m(unsigned long pfn)
> +bool __init __early_alloc_p2m(unsigned long pfn)

__early_alloc_p2m could be static as well.
-- 

  reply	other threads:[~2011-03-24 21:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-24 20:34 [PATCH] xen: fix p2m section mismatches Randy Dunlap
2011-03-24 21:48 ` Stephen Hemminger [this message]
2011-03-25 15:06   ` [Xen-devel] " Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110324144802.1def1400@nehalam \
    --to=shemminger@vyatta.com \
    --cc=akpm@linux-foundation.org \
    --cc=jeremy.fitzhardinge@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=randy.dunlap@oracle.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox