Linux virtualization list
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: jason@lakedaemon.net, linux-kernel@vger.kernel.org,
	keescook@chromium.org,
	Virtualization List <virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH v3 0/2] hwrng, virtio-rng: init-time fixes
Date: Tue, 15 Jul 2014 10:10:28 +0530	[thread overview]
Message-ID: <20140715044028.GA26186@grmbl.mre> (raw)
In-Reply-To: <20140714125006.GA9958@gondor.apana.org.au>

On (Mon) 14 Jul 2014 [20:50:06], Herbert Xu wrote:
> On Thu, Jul 10, 2014 at 03:42:33PM +0530, Amit Shah wrote:
> > v3:
> >  - Kees Cook pointed out a weird side-effect: devices which have
> >    ->init() registered get their randomness added to the system each
> >    time they're switched in, but devices that don't have the init
> >    callback don't contribute to system randomness more than once.  The
> >    weirdness is resolved here by using the randomness each time
> >    hwrng_init() is attempted, irrespective of the existence of the
> >    device's ->init() callback.
> 
> All applied to crypto.  Thanks!

Thanks, Herbert.  I didn't mention it, but pls queue it up for 3.16.


		Amit

  reply	other threads:[~2014-07-15  4:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-10 10:12 [PATCH v3 0/2] hwrng, virtio-rng: init-time fixes Amit Shah
2014-07-10 10:12 ` [PATCH v3 1/2] hwrng: fetch randomness only after device init Amit Shah
2014-07-10 11:13   ` Jason Cooper
2014-07-10 10:12 ` [PATCH v3 2/2] virtio: rng: ensure reads happen after successful probe Amit Shah
2014-07-14 12:50 ` [PATCH v3 0/2] hwrng, virtio-rng: init-time fixes Herbert Xu
2014-07-15  4:40   ` Amit Shah [this message]
2014-07-15  4:45     ` Herbert Xu
2014-07-15  4:49       ` Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140715044028.GA26186@grmbl.mre \
    --to=amit.shah@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jason@lakedaemon.net \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox