* Re: [PATCH 3/3] drm/qxl: Remove fbcon acceleration leftovers
2020-10-29 10:14 ` [PATCH 3/3] drm/qxl: Remove fbcon acceleration leftovers Daniel Vetter
@ 2020-10-29 11:13 ` Gerd Hoffmann
2020-10-29 13:33 ` [PATCH] " Daniel Vetter
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Gerd Hoffmann @ 2020-10-29 11:13 UTC (permalink / raw)
To: Daniel Vetter
Cc: Dave Airlie, Intel Graphics Development, DRI Development,
virtualization, spice-devel, Daniel Vetter
On Thu, Oct 29, 2020 at 11:14:28AM +0100, Daniel Vetter wrote:
> These are leftovers from 13aff184ed9f ("drm/qxl: remove dead qxl fbdev
> emulation code").
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] drm/qxl: Remove fbcon acceleration leftovers
2020-10-29 10:14 ` [PATCH 3/3] drm/qxl: Remove fbcon acceleration leftovers Daniel Vetter
2020-10-29 11:13 ` Gerd Hoffmann
@ 2020-10-29 13:33 ` Daniel Vetter
2020-11-17 10:01 ` Daniel Vetter
2020-10-29 13:56 ` [PATCH 3/3] " kernel test robot
2020-10-30 0:37 ` kernel test robot
3 siblings, 1 reply; 6+ messages in thread
From: Daniel Vetter @ 2020-10-29 13:33 UTC (permalink / raw)
To: DRI Development
Cc: spice-devel, Daniel Vetter, Intel Graphics Development,
virtualization, Daniel Vetter, Dave Airlie
These are leftovers from 13aff184ed9f ("drm/qxl: remove dead qxl fbdev
emulation code").
v2: Somehow these structs provided the struct qxl_device pre-decl,
reorder the header to not anger compilers.
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: virtualization@lists.linux-foundation.org
Cc: spice-devel@lists.freedesktop.org
---
drivers/gpu/drm/qxl/qxl_drv.h | 18 ++----------------
1 file changed, 2 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h
index 3602e8b34189..6239626503ef 100644
--- a/drivers/gpu/drm/qxl/qxl_drv.h
+++ b/drivers/gpu/drm/qxl/qxl_drv.h
@@ -166,20 +166,6 @@ struct qxl_drm_image {
struct list_head chunk_list;
};
-struct qxl_fb_image {
- struct qxl_device *qdev;
- uint32_t pseudo_palette[16];
- struct fb_image fb_image;
- uint32_t visual;
-};
-
-struct qxl_draw_fill {
- struct qxl_device *qdev;
- struct qxl_rect rect;
- uint32_t color;
- uint16_t rop;
-};
-
/*
* Debugfs
*/
@@ -188,8 +174,6 @@ struct qxl_debugfs {
unsigned int num_files;
};
-int qxl_debugfs_fence_init(struct qxl_device *rdev);
-
struct qxl_device {
struct drm_device ddev;
@@ -271,6 +255,8 @@ struct qxl_device {
#define to_qxl(dev) container_of(dev, struct qxl_device, ddev)
+int qxl_debugfs_fence_init(struct qxl_device *rdev);
+
extern const struct drm_ioctl_desc qxl_ioctls[];
extern int qxl_max_ioctl;
--
2.28.0
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm/qxl: Remove fbcon acceleration leftovers
2020-10-29 13:33 ` [PATCH] " Daniel Vetter
@ 2020-11-17 10:01 ` Daniel Vetter
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2020-11-17 10:01 UTC (permalink / raw)
To: DRI Development
Cc: spice-devel, Daniel Vetter, Intel Graphics Development,
virtualization, Daniel Vetter, Dave Airlie
On Thu, Oct 29, 2020 at 02:33:47PM +0100, Daniel Vetter wrote:
> These are leftovers from 13aff184ed9f ("drm/qxl: remove dead qxl fbdev
> emulation code").
>
> v2: Somehow these structs provided the struct qxl_device pre-decl,
> reorder the header to not anger compilers.
>
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: virtualization@lists.linux-foundation.org
> Cc: spice-devel@lists.freedesktop.org
Entire series applied to drm-misc-next.
-Daniel
> ---
> drivers/gpu/drm/qxl/qxl_drv.h | 18 ++----------------
> 1 file changed, 2 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h
> index 3602e8b34189..6239626503ef 100644
> --- a/drivers/gpu/drm/qxl/qxl_drv.h
> +++ b/drivers/gpu/drm/qxl/qxl_drv.h
> @@ -166,20 +166,6 @@ struct qxl_drm_image {
> struct list_head chunk_list;
> };
>
> -struct qxl_fb_image {
> - struct qxl_device *qdev;
> - uint32_t pseudo_palette[16];
> - struct fb_image fb_image;
> - uint32_t visual;
> -};
> -
> -struct qxl_draw_fill {
> - struct qxl_device *qdev;
> - struct qxl_rect rect;
> - uint32_t color;
> - uint16_t rop;
> -};
> -
> /*
> * Debugfs
> */
> @@ -188,8 +174,6 @@ struct qxl_debugfs {
> unsigned int num_files;
> };
>
> -int qxl_debugfs_fence_init(struct qxl_device *rdev);
> -
> struct qxl_device {
> struct drm_device ddev;
>
> @@ -271,6 +255,8 @@ struct qxl_device {
>
> #define to_qxl(dev) container_of(dev, struct qxl_device, ddev)
>
> +int qxl_debugfs_fence_init(struct qxl_device *rdev);
> +
> extern const struct drm_ioctl_desc qxl_ioctls[];
> extern int qxl_max_ioctl;
>
> --
> 2.28.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] drm/qxl: Remove fbcon acceleration leftovers
2020-10-29 10:14 ` [PATCH 3/3] drm/qxl: Remove fbcon acceleration leftovers Daniel Vetter
2020-10-29 11:13 ` Gerd Hoffmann
2020-10-29 13:33 ` [PATCH] " Daniel Vetter
@ 2020-10-29 13:56 ` kernel test robot
2020-10-30 0:37 ` kernel test robot
3 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2020-10-29 13:56 UTC (permalink / raw)
To: Daniel Vetter, DRI Development
Cc: kbuild-all, Daniel Vetter, Intel Graphics Development,
virtualization, Dave Airlie, spice-devel
[-- Attachment #1: Type: text/plain, Size: 2195 bytes --]
Hi Daniel,
I love your patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master drm/drm-next v5.10-rc1 next-20201028]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/fbcon-Disable-accelerated-scrolling/20201029-181618
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: alpha-randconfig-r003-20201029 (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/188b22d2b66860695df5d07bf2b7115976790b2c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Daniel-Vetter/fbcon-Disable-accelerated-scrolling/20201029-181618
git checkout 188b22d2b66860695df5d07bf2b7115976790b2c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from drivers/gpu/drm/qxl/qxl_drv.c:31:
>> drivers/gpu/drm/qxl/qxl_drv.h:178:35: warning: 'struct qxl_device' declared inside parameter list will not be visible outside of this definition or declaration
178 | int qxl_debugfs_fence_init(struct qxl_device *rdev);
| ^~~~~~~~~~
vim +178 drivers/gpu/drm/qxl/qxl_drv.h
f64122c1f6ade30 Dave Airlie 2013-02-25 177
f64122c1f6ade30 Dave Airlie 2013-02-25 @178 int qxl_debugfs_fence_init(struct qxl_device *rdev);
f64122c1f6ade30 Dave Airlie 2013-02-25 179
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27013 bytes --]
[-- Attachment #3: Type: text/plain, Size: 183 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 3/3] drm/qxl: Remove fbcon acceleration leftovers
2020-10-29 10:14 ` [PATCH 3/3] drm/qxl: Remove fbcon acceleration leftovers Daniel Vetter
` (2 preceding siblings ...)
2020-10-29 13:56 ` [PATCH 3/3] " kernel test robot
@ 2020-10-30 0:37 ` kernel test robot
3 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2020-10-30 0:37 UTC (permalink / raw)
To: Daniel Vetter, DRI Development
Cc: kbuild-all, Daniel Vetter, Intel Graphics Development,
virtualization, clang-built-linux, Dave Airlie, spice-devel
[-- Attachment #1: Type: text/plain, Size: 2352 bytes --]
Hi Daniel,
I love your patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.10-rc1 next-20201029]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/fbcon-Disable-accelerated-scrolling/20201029-181618
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: powerpc-randconfig-r015-20201029 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 772aaa602383cf82795572ebcd86b0e660f3579f)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc cross compiling tool for clang build
# apt-get install binutils-powerpc-linux-gnu
# https://github.com/0day-ci/linux/commit/188b22d2b66860695df5d07bf2b7115976790b2c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Daniel-Vetter/fbcon-Disable-accelerated-scrolling/20201029-181618
git checkout 188b22d2b66860695df5d07bf2b7115976790b2c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from drivers/gpu/drm/qxl/qxl_drv.c:31:
>> drivers/gpu/drm/qxl/qxl_drv.h:178:35: warning: declaration of 'struct qxl_device' will not be visible outside of this function [-Wvisibility]
int qxl_debugfs_fence_init(struct qxl_device *rdev);
^
1 warning generated.
vim +178 drivers/gpu/drm/qxl/qxl_drv.h
f64122c1f6ade30 Dave Airlie 2013-02-25 177
f64122c1f6ade30 Dave Airlie 2013-02-25 @178 int qxl_debugfs_fence_init(struct qxl_device *rdev);
f64122c1f6ade30 Dave Airlie 2013-02-25 179
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31155 bytes --]
[-- Attachment #3: Type: text/plain, Size: 183 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 6+ messages in thread