Linux virtualization list
 help / color / mirror / Atom feed
* [PATCH] virtio: vdpa: explain the dependency of SNET_VDPA on HWMON
@ 2022-12-20  9:07 Alvaro Karsz
  2022-12-21  3:25 ` Jason Wang
  0 siblings, 1 reply; 6+ messages in thread
From: Alvaro Karsz @ 2022-12-20  9:07 UTC (permalink / raw)
  To: virtualization; +Cc: Michael S. Tsirkin

Add a comment in Kconfig explaining the
"depends on .. && (HWMON || HWMON=n)" part.

This patch should be applied on top of the following patch:

virtio: vdpa: new SolidNET DPU driver,
by Alvaro Karsz alvaro.karsz@solid-run.com

Signed-off-by: Alvaro Karsz <alvaro.karsz@solid-run.com>
---
 drivers/vdpa/Kconfig | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig
index 79625c7cc46..7396e92b485 100644
--- a/drivers/vdpa/Kconfig
+++ b/drivers/vdpa/Kconfig
@@ -89,6 +89,14 @@ config ALIBABA_ENI_VDPA
  config SNET_VDPA
 	tristate "SolidRun's vDPA driver for SolidNET"
 	depends on PCI_MSI && PCI_IOV && (HWMON || HWMON=n)
+
+	# This driver MAY create a HWMON device.
+	# Depending on (HWMON || HWMON=n) ensures that:
+	# If HWMON=n the driver can be compiled either as a module or built-in.
+	# If HWMON=y the driver can be compiled either as a module or built-in.
+	# If HWMON=m the driver is forced to be compiled as a module.
+	# By doing so, IS_ENABLED can be used instead of IS_REACHABLE
+
 	help
 	  vDPA driver for SolidNET DPU.
 	  With this driver, the VirtIO dataplane can be
-- 
2.32.0

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] virtio: vdpa: explain the dependency of SNET_VDPA on HWMON
  2022-12-20  9:07 [PATCH] virtio: vdpa: explain the dependency of SNET_VDPA on HWMON Alvaro Karsz
@ 2022-12-21  3:25 ` Jason Wang
  2022-12-29 12:13   ` Alvaro Karsz
  0 siblings, 1 reply; 6+ messages in thread
From: Jason Wang @ 2022-12-21  3:25 UTC (permalink / raw)
  To: Alvaro Karsz; +Cc: Michael S. Tsirkin, virtualization

On Tue, Dec 20, 2022 at 5:07 PM Alvaro Karsz <alvaro.karsz@solid-run.com> wrote:
>
> Add a comment in Kconfig explaining the
> "depends on .. && (HWMON || HWMON=n)" part.
>
> This patch should be applied on top of the following patch:
>
> virtio: vdpa: new SolidNET DPU driver,
> by Alvaro Karsz alvaro.karsz@solid-run.com
>
> Signed-off-by: Alvaro Karsz <alvaro.karsz@solid-run.com>

Acked-by: Jason Wang <jasowang@redhat.com>

Thanks

> ---
>  drivers/vdpa/Kconfig | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig
> index 79625c7cc46..7396e92b485 100644
> --- a/drivers/vdpa/Kconfig
> +++ b/drivers/vdpa/Kconfig
> @@ -89,6 +89,14 @@ config ALIBABA_ENI_VDPA
>   config SNET_VDPA
>         tristate "SolidRun's vDPA driver for SolidNET"
>         depends on PCI_MSI && PCI_IOV && (HWMON || HWMON=n)
> +
> +       # This driver MAY create a HWMON device.
> +       # Depending on (HWMON || HWMON=n) ensures that:
> +       # If HWMON=n the driver can be compiled either as a module or built-in.
> +       # If HWMON=y the driver can be compiled either as a module or built-in.
> +       # If HWMON=m the driver is forced to be compiled as a module.
> +       # By doing so, IS_ENABLED can be used instead of IS_REACHABLE
> +
>         help
>           vDPA driver for SolidNET DPU.
>           With this driver, the VirtIO dataplane can be
> --
> 2.32.0
>

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] virtio: vdpa: explain the dependency of SNET_VDPA on HWMON
  2022-12-21  3:25 ` Jason Wang
@ 2022-12-29 12:13   ` Alvaro Karsz
  2022-12-29 13:32     ` Michael S. Tsirkin
  0 siblings, 1 reply; 6+ messages in thread
From: Alvaro Karsz @ 2022-12-29 12:13 UTC (permalink / raw)
  To: Michael S. Tsirkin; +Cc: virtualization

Hi Michael,

Is this patch ok with you?
Do you have any comments?
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] virtio: vdpa: explain the dependency of SNET_VDPA on HWMON
  2022-12-29 12:13   ` Alvaro Karsz
@ 2022-12-29 13:32     ` Michael S. Tsirkin
  2022-12-29 13:34       ` Alvaro Karsz
  0 siblings, 1 reply; 6+ messages in thread
From: Michael S. Tsirkin @ 2022-12-29 13:32 UTC (permalink / raw)
  To: Alvaro Karsz; +Cc: virtualization

On Thu, Dec 29, 2022 at 02:13:57PM +0200, Alvaro Karsz wrote:
> Hi Michael,
> 
> Is this patch ok with you?
> Do you have any comments?

It's ok. I had to push everything out to next merge window
though. Sorry :(

-- 
MST

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] virtio: vdpa: explain the dependency of SNET_VDPA on HWMON
  2022-12-29 13:32     ` Michael S. Tsirkin
@ 2022-12-29 13:34       ` Alvaro Karsz
  2023-01-08  8:58         ` Alvaro Karsz
  0 siblings, 1 reply; 6+ messages in thread
From: Alvaro Karsz @ 2022-12-29 13:34 UTC (permalink / raw)
  To: Michael S. Tsirkin; +Cc: virtualization

> It's ok. I had to push everything out to next merge window
> though. Sorry :(

Don't worry about it :)
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] virtio: vdpa: explain the dependency of SNET_VDPA on HWMON
  2022-12-29 13:34       ` Alvaro Karsz
@ 2023-01-08  8:58         ` Alvaro Karsz
  0 siblings, 0 replies; 6+ messages in thread
From: Alvaro Karsz @ 2023-01-08  8:58 UTC (permalink / raw)
  To: Michael S. Tsirkin; +Cc: virtualization

Hi Michael,
This patch was merged into:
[PATCH v7] virtio: vdpa: new SolidNET DPU driver.
So it can be ignored.
Thank you.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-01-08  8:59 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-20  9:07 [PATCH] virtio: vdpa: explain the dependency of SNET_VDPA on HWMON Alvaro Karsz
2022-12-21  3:25 ` Jason Wang
2022-12-29 12:13   ` Alvaro Karsz
2022-12-29 13:32     ` Michael S. Tsirkin
2022-12-29 13:34       ` Alvaro Karsz
2023-01-08  8:58         ` Alvaro Karsz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox