From: Bjorn Helgaas <helgaas@kernel.org>
To: Alvaro Karsz <alvaro.karsz@solid-run.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org, mst@redhat.com,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v8 1/3] PCI: Add SolidRun vendor ID
Date: Tue, 10 Jan 2023 09:34:34 -0600 [thread overview]
Message-ID: <20230110153434.GA1505598@bhelgaas> (raw)
In-Reply-To: <20230109080453.1155113-1-alvaro.karsz@solid-run.com>
On Mon, Jan 09, 2023 at 10:04:53AM +0200, Alvaro Karsz wrote:
> Add SolidRun vendor ID to pci_ids.h
>
> The vendor ID is used in 2 different source files,
> the SNET vDPA driver and PCI quirks.
Nits: wrap to fill 75 columns.
> Signed-off-by: Alvaro Karsz <alvaro.karsz@solid-run.com>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> include/linux/pci_ids.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index b362d90eb9b..9a3102e61db 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -3092,6 +3092,8 @@
>
> #define PCI_VENDOR_ID_3COM_2 0xa727
>
> +#define PCI_VENDOR_ID_SOLIDRUN 0xd063
This should be indented with tabs instead of spaces so it matches the
rest of the file.
It's helpful if you can send the patches in a series so the individual
patches are replies to the cover letter. That makes tools and
archives work better:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/5.Posting.rst?id=v6.1#n342
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-01-10 15:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 8:04 [PATCH v8 1/3] PCI: Add SolidRun vendor ID Alvaro Karsz
2023-01-10 15:34 ` Bjorn Helgaas [this message]
2023-01-10 15:46 ` Alvaro Karsz
2023-01-10 16:12 ` Bjorn Helgaas
2023-01-10 16:39 ` Alvaro Karsz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110153434.GA1505598@bhelgaas \
--to=helgaas@kernel.org \
--cc=alvaro.karsz@solid-run.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox