[PATCH v8 1/3] PCI: Add SolidRun vendor ID

[PATCH v8 1/3] PCI: Add SolidRun vendor ID

[Alvaro Karsz]

Add SolidRun vendor ID to pci_ids.h

The vendor ID is used in 2 different source files,
the SNET vDPA driver and PCI quirks.

Signed-off-by: Alvaro Karsz <alvaro.karsz@solid-run.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
---
 include/linux/pci_ids.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index b362d90eb9b..9a3102e61db 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -3092,6 +3092,8 @@

 #define PCI_VENDOR_ID_3COM_2		0xa727

+#define PCI_VENDOR_ID_SOLIDRUN          0xd063
+
 #define PCI_VENDOR_ID_DIGIUM		0xd161
 #define PCI_DEVICE_ID_DIGIUM_HFC4S	0xb410

--
2.32.0
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v8 1/3] PCI: Add SolidRun vendor ID

[Bjorn Helgaas]

On Mon, Jan 09, 2023 at 10:04:53AM +0200, Alvaro Karsz wrote:
> Add SolidRun vendor ID to pci_ids.h
> 
> The vendor ID is used in 2 different source files,
> the SNET vDPA driver and PCI quirks.

Nits: wrap to fill 75 columns.

> Signed-off-by: Alvaro Karsz <alvaro.karsz@solid-run.com>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
>  include/linux/pci_ids.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index b362d90eb9b..9a3102e61db 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -3092,6 +3092,8 @@
> 
>  #define PCI_VENDOR_ID_3COM_2		0xa727
> 
> +#define PCI_VENDOR_ID_SOLIDRUN          0xd063

This should be indented with tabs instead of spaces so it matches the
rest of the file.

It's helpful if you can send the patches in a series so the individual
patches are replies to the cover letter.  That makes tools and
archives work better:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/5.Posting.rst?id=v6.1#n342
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v8 1/3] PCI: Add SolidRun vendor ID

[Alvaro Karsz]

Thanks Bjorn.

> This should be indented with tabs instead of spaces so it matches the
> rest of the file.

Michael, sorry about all the versions..
Do you want me to fix it in a new version?
I could fix it with a patch directly to the pci maintainers after your
linux-next is merged, if this is ok with everyone.

> It's helpful if you can send the patches in a series so the individual
> patches are replies to the cover letter.  That makes tools and
> archives work better:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/5.Posting.rst?id=v6.1#n342

Yes, I fixed it in the next version:
https://lists.linuxfoundation.org/pipermail/virtualization/2023-January/064190.html

Alvaro
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v8 1/3] PCI: Add SolidRun vendor ID

[Bjorn Helgaas]

On Tue, Jan 10, 2023 at 05:46:37PM +0200, Alvaro Karsz wrote:
> > This should be indented with tabs instead of spaces so it matches the
> > rest of the file.
> 
> Michael, sorry about all the versions..
> Do you want me to fix it in a new version?
> I could fix it with a patch directly to the pci maintainers after your
> linux-next is merged, if this is ok with everyone.

It's not worth merging this patch and then adding another patch on top
just to convert spaces to tabs.

> > It's helpful if you can send the patches in a series so the individual
> > patches are replies to the cover letter.  That makes tools and
> > archives work better:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/5.Posting.rst?id=v6.1#n342
> 
> Yes, I fixed it in the next version:
> https://lists.linuxfoundation.org/pipermail/virtualization/2023-January/064190.html

It doesn't look fixed to me.  The "lore" archive is better than
pipermail, and the cover letter doesn't show any replies:
https://lore.kernel.org/linux-pci/20230109080429.1155046-1-alvaro.karsz@solid-run.com/

If you look at https://lore.kernel.org/linux-pci/, you'll see the
typical thread structure with patches nested under the cover letter.
The patches have "In-Reply-To" headers that reference the cover
letter.

Bjorn
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v8 1/3] PCI: Add SolidRun vendor ID

[Alvaro Karsz]

Ok, I'll send a new version
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization